Bug 4338 - [review] Incorrect IANA Reserved range
Summary: [review] Incorrect IANA Reserved range
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 3.0.3
Hardware: All All
: P3 normal
Target Milestone: 3.0.4
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
: 4350 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-05-17 21:36 UTC by Eric Brewer
Modified: 2005-05-26 15:06 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
backport trunk r124857 to 3.0 patch None Daryl C. W. O'Shea [HasCLA]
Simple patch patch None Tom Schulz [NoCLA]
patch against 3.0 patch None Daryl C. W. O'Shea [HasCLA]
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Brewer 2005-05-17 21:36:12 UTC 
Constants.pm specifies incorrect IANA Reserved range: 071-079/8 instead of 074-
079/8. (I have just received spam from an open proxy at 71.106.26.62.) BTW, I 
believe that 046/8 is reserved, too.
Comment 1 Daryl C. W. O'Shea 2005-05-17 23:21:45 UTC 
This was fixed in trunk but apparently forgotten in 3.0 (since there wasn't
going to be any more 3.0 releases at that time).
Comment 2 Daryl C. W. O'Shea 2005-05-20 18:56:05 UTC 
Created attachment 2887 [details]
backport trunk r124857 to 3.0
Comment 3 Daryl C. W. O'Shea 2005-05-20 18:58:08 UTC 
*** Bug 4350 has been marked as a duplicate of this bug. ***
Comment 4 Daryl C. W. O'Shea 2005-05-21 15:16:24 UTC 
Comment on attachment 2887 [details]
backport trunk r124857 to 3.0

This patch isn't complete -- it's missing the updated POD & debug messages.
Comment 5 era eriksson 2005-05-23 05:13:33 UTC 
I looked at the code on the trunk but the change seemed to overarching for
3.0.x. I'm not sure I understand the context of Daniel's change.

Anyway, just for the record, bug 4350 contains a backport (if you can call it
that -- it's just a minimal fix) of a much more modest change.

Either way, the code in 3.0.3 is wrong for 71.0.0.0/8 and 72.0.0.0/8 (I didn't
know about 73.0.0.0/8 -- are you sure?)
Comment 6 Tom Schulz 2005-05-23 06:21:50 UTC 
Created attachment 2892 [details]
Simple patch

For 3.04, keep it simple.  To do it the 3.1 way, you would need both R124829
and R124857.  The final result mostly just removes the reserved stuff.	The
attached patch does this and is what I have been running.
Comment 7 Daryl C. W. O'Shea 2005-05-24 00:36:16 UTC 
Created attachment 2895 [details]
patch against 3.0

Yeah, I'm happy with keeping the existing variable and constant names
(IP_IN_RESERVED_RANGE vs IP_PRIVATE) to be consistent with the rest of the 3.0
releases.

This patch updates the POD in Conf.pm to reflect only private ranges being
included.
Comment 8 Theo Van Dinter 2005-05-26 19:32:21 UTC 
+1 2895
Comment 9 Justin Mason 2005-05-26 20:59:26 UTC 
+1 for 2895
Comment 10 Daryl C. W. O'Shea 2005-05-26 23:06:57 UTC 
3.0 r178758