Bug 4379 - warns/dies appear to be hidden by new Logger code
Summary: warns/dies appear to be hidden by new Logger code
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 major
Target Milestone: 3.1.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-01 19:02 UTC by Justin Mason
Modified: 2005-06-07 12:40 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2005-06-01 19:02:18 UTC
I note this in Logger.pm:


sub log_message {
  my ($level, @message) = @_;

  # too many die and warn messages out there, don't log the
  # ones that we don't own
  if ($level eq "error" or $level eq "warn") {
    return unless $message[0] =~ /^\S+:/;
  }

  [....]
}

sure enough, if you add a line like
 
   warn "foo: help!"

to an eval test, it appears -- but without the "foo:" prefix, it's invisible.
I'm checking in code to turn this off; this bug should be used as a forum to
discuss this, if it's required.
Comment 1 Justin Mason 2005-06-01 19:03:08 UTC
r179485.
Comment 2 Justin Mason 2005-06-07 20:40:58 UTC
hmm, I was assuming there'd be more controversy seeing as the change was in
there in the first place ;)   closing this bug.