Bug 4480 - test failure in pre4 candidate due to meta.t bug
Summary: test failure in pre4 candidate due to meta.t bug
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Regression Tests (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 blocker
Target Milestone: 3.1.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-12 18:27 UTC by Justin Mason
Modified: 2005-07-13 03:16 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
drat. patch patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2005-07-12 18:27:09 UTC 
PYZOR_CHECK was given a non-zero score in scoresets 0 and 2.  this had the
unfortunate side-effect of triggering a bug in meta.t -- it didn't like the idea
that some of the predicates (but not all) had zero scores, so issued a test failure.

this is causing test failures in the pre4 candidate tarballs -- but not on all
platforms, since meta.t relies on being able to run parse-rules-for-masses.  So
only if you have the Storable module installed. urgh.

the fix is for meta.t to allow predicate rules to have zero scores in some
scoresets if the rules are "tflags net" or "tflags learn".

patch to follow.
Comment 1 Justin Mason 2005-07-12 18:27:40 UTC 
Created attachment 3022 [details]
drat.  patch

here's the fix.
Comment 2 Justin Mason 2005-07-12 18:29:52 UTC 
this may block the 3.1.0-pre4 candidate I just posted.

we need to decide if we want to cut a new tarball to fix this test-suite bug, or
just ignore the bug since it doesn't effect the actual workings of the product
(it's a test suite bug only).  I vote the latter. ;)

the fix should be applied to svn eventually anyway, of course.
Comment 3 Justin Mason 2005-07-13 11:16:45 UTC 
checked it in as a trivial fix, since it's the addition of one statement (and
about 5 lines of explanatory comments) in a t script, revision 216202.