Bug 4552 - [review] Unitialized value warnings in spamd
Summary: [review] Unitialized value warnings in spamd
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: 3.1.0
Hardware: Other other
: P5 major
Target Milestone: 3.1.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: ready to apply
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-21 21:14 UTC by Duncan Findlay
Modified: 2005-08-27 12:29 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Patch to fix this patch None Duncan Findlay [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan Findlay 2005-08-21 21:14:18 UTC 
I'm assuming sample-spam.txt was originally learned as spam.

./spamc/spamc -p 12345 -L spam < sample-spam.txt

in the debug output from spamd:
[2391] warn: Use of uninitialized value in concatenation (.) or string at
./spamd line 1484, <GEN5> line 32.
[2391] warn: Use of uninitialized value in concatenation (.) or string at
./spamd line 1489, <GEN5> line 32.
[2391] warn: Use of uninitialized value in concatenation (.) or string at
./spamd line 1489, <GEN5> line 32.
[2391] info: spamd: for duncf:1000 in 0.1 seconds, 799 bytes

./spamc/spamc -p 12345 -L ham < sample-spam.txt

debug output:
[2391] warn: Use of uninitialized value in concatenation (.) or string at
./spamd line 1489, <GEN7> line 32.
[2391] info: spamd: Setting local  for duncf:1000 in 0.2 seconds, 799 bytes


./spamc/spamc -p 12345 -L spam < sample-spam.txt

debug output:
[2391] warn: Use of uninitialized value in concatenation (.) or string at
./spamd line 1489, <GEN8> line 32.
[2391] info: spamd: Setting local  for duncf:1000 in 0.2 seconds, 799 bytes


Note the "Setting " lines are missing information that seems important.
Comment 1 Duncan Findlay 2005-08-27 18:20:56 UTC 
Created attachment 3105 [details]
Patch to fix this

This fixed the uninitialized value warnings and makes the log message make
sense if the message was not learned/unlearned.
Comment 2 Duncan Findlay 2005-08-27 18:22:47 UTC 
Please vote on attachment 3105 [details] for 3.1.0. Fixed in trunk (261912).
Comment 3 Theo Van Dinter 2005-08-27 18:42:30 UTC 
+1
Comment 4 Sidney Markowitz 2005-08-27 20:14:08 UTC 
+1
Comment 5 Duncan Findlay 2005-08-27 20:29:18 UTC 
Sending        spamd/spamd.raw
Transmitting file data .
Committed revision 263805.