Bug 4586 - [review] spamd information message tells user to use switch that doesn't exist in spamd
[review] spamd information message tells user to use switch that doesn't exis...
Status: RESOLVED FIXED
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd
3.1.0
Other other
: P5 trivial
: 3.1.1
Assigned To: SpamAssassin Developer Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2005-09-15 08:19 UTC by brian mastro
Modified: 2005-09-20 12:41 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status
patch patch None Daryl C. W. O'Shea [HasCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description brian mastro 2005-09-15 08:19:13 UTC
spamd is reporting:
@400000004329884632c8e09c [13810] info: prefork: server reached --max-clients
setting, consider raising it

if you use this switch however:

# spamd -V
SpamAssassin Server version 3.1.0
  running on Perl 5.8.0
  with SSL support (IO::Socket::SSL 0.97)
# spamd --max-clients=1
[32593] warn: Unknown option: max-clients


checking the source quickly ...
# grep -R max-clients *
blib/lib/Mail/SpamAssassin/SpamdForkScaling.pm:      info("prefork: server
reached --max-clients setting, consider raising it\n");
Changes:change "--max-clients" and "child states" warnings into info, these
lib/Mail/SpamAssassin/SpamdForkScaling.pm:      info("prefork: server reached
--max-clients setting, consider raising it\n");
Comment 1 Daryl C. W. O'Shea 2005-09-15 10:17:48 UTC
The info message should really refer to "--max-children" or "-m".
Comment 2 Daryl C. W. O'Shea 2005-09-20 20:10:07 UTC
Created attachment 3144 [details]
patch

trunk: Committed revision 290606.
Comment 3 Theo Van Dinter 2005-09-20 20:12:41 UTC
+1
Comment 4 Sidney Markowitz 2005-09-20 20:25:09 UTC
+1
Comment 5 Justin Mason 2005-09-20 20:28:31 UTC
+1
Comment 6 Daryl C. W. O'Shea 2005-09-20 20:41:22 UTC
3.1: Committed revision 290610.