Bug 4656 - AWL throws unnecessary error if lockfile creation failed
Summary: AWL throws unnecessary error if lockfile creation failed
Status: RESOLVED DUPLICATE of bug 4617
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: 3.1.0
Hardware: Other Linux
: P5 trivial
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-31 17:54 UTC by Jamie McCarthy
Modified: 2005-10-31 09:24 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
One-liner fix patch None Jamie McCarthy [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jamie McCarthy 2005-10-31 17:54:39 UTC 
If Plugin/AWL.pm fails to create a lock file, $whitelist remains undef and the eval attempt to clean it up 
drops an unnecessary error line (into my syslog):

Oct 31 11:33:26 ralph spamd[643]: Can't call method "finish" on an undefined value at /usr/share/perl5/
Mail/SpamAssassin/Plugin/AWL.pm line 397.

The one-liner fix is probably obvious but I'll attach a patch in a moment, anyway.
Comment 1 Jamie McCarthy 2005-10-31 17:55:40 UTC 
Created attachment 3221 [details]
One-liner fix
Comment 2 Daryl C. W. O'Shea 2005-10-31 18:24:55 UTC 

*** This bug has been marked as a duplicate of 4617 ***