Bug 4795 - [review] score config option isn't validated very well
Summary: [review] score config option isn't validated very well
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 3.1.1
Assignee: Daryl C. W. O'Shea
URL:
Whiteboard: ready
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-14 22:17 UTC by Daryl C. W. O'Shea
Modified: 2006-02-23 14:44 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
3.1 patch patch None Daryl C. W. O'Shea [HasCLA]
3.1 patch patch None Daryl C. W. O'Shea [HasCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daryl C. W. O'Shea 2006-02-14 22:17:33 UTC 
score RULE_NAME n.nn   # literally n.nn, if you can believe that

[10272] warn: Argument "n.nn" isn't numeric in addition (+) at
/usr/lib/perl5/site_perl/5.8.0/Mail/SpamAssassin/Conf.pm line 251.
[10272] warn: Argument "n.nn" isn't numeric in addition (+) at
/usr/lib/perl5/site_perl/5.8.0/Mail/SpamAssassin/Conf.pm line 251.
[10272] warn: Argument "n.nn" isn't numeric in addition (+) at
/usr/lib/perl5/site_perl/5.8.0/Mail/SpamAssassin/Conf.pm line 251.
[10272] warn: Argument "n.nn" isn't numeric in addition (+) at
/usr/lib/perl5/site_perl/5.8.0/Mail/SpamAssassin/Conf.pm line 251.
Comment 1 Daryl C. W. O'Shea 2006-02-14 22:19:41 UTC 
trunk:
Sending        lib/Mail/SpamAssassin/Conf.pm
Transmitting file data .
Committed revision 377834.
Comment 2 Daryl C. W. O'Shea 2006-02-14 22:40:43 UTC 
Created attachment 3372 [details]
3.1 patch
Comment 3 Michael Parker 2006-02-14 23:09:27 UTC 
+1
Comment 4 Theo Van Dinter 2006-02-14 23:18:48 UTC 
I'm leaning towards a -1 on this patch for the same reasons as the 3.2 patch.  See 
<20060214221623.GT12823@kluge.net> on the dev@ list.
Comment 5 Michael Parker 2006-02-14 23:25:58 UTC 
I didn't notice the change in the return value.  I agree with Theo, and revoke
my +1 for now.
Comment 6 Daryl C. W. O'Shea 2006-02-15 01:13:09 UTC 
trunk: r377905 removes the lint_warn()s and restores the return values
Comment 7 Daryl C. W. O'Shea 2006-02-15 01:34:49 UTC 
Created attachment 3373 [details]
3.1 patch

uses info()s instead of lint_warn()s

Please review again...
Comment 8 Theo Van Dinter 2006-02-22 05:11:25 UTC 
+1 on 3373

looks good.  thanks for making the changes. :)
Comment 9 Justin Mason 2006-02-23 14:08:04 UTC 
+1
Comment 10 Justin Mason 2006-02-23 23:44:39 UTC 
applied! r380258 on b3_1_0 branch