Bug 4867 - [review] UNPARSEABLE_RELAY is fetchmail
Summary: [review] UNPARSEABLE_RELAY is fetchmail
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 3.1.1
Hardware: PC Linux
: P3 trivial
Target Milestone: 3.1.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: can be committed
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-13 13:40 UTC by David Greenhouse
Modified: 2006-05-01 20:33 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
fix for b310 patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Greenhouse 2006-04-13 13:40:12 UTC 
i386 Fedora Core 5, spamassassin-3.1.0-5.fc5.2

The version of fetchmail I use (i386 FC5 - fetchmail-6.3.2.1-1.2) does not 
include an IP address in the 'Received:' line it adds, triggering an 
UNPARSEABLE_RELAY hit on all messages, ham or spam. e.g.

Received: from imap.tiscali.co.uk
	by myhost.localnet with IMAP (fetchmail-6.3.2)
	for <me@mail.example.com> (multi-drop); Thu, 13 Apr 2006 07:00:18 +0100 
(BST)

Tracked it down 
to '/usr/lib/perl5/vendor_perl/5.8.8/Mail/SpamAssassin/Message/Metadata/Received
.pm', line 1183. Changing the line from:

    if (/^from (\S+) \[(${IP_ADDRESS})\] by (\S+) with \S+ \(fetchmail/) {

to:

    if (/^from (\S+) (\[(${IP_ADDRESS})\] )?by (\S+) with \S+ \(fetchmail/) {

appears to fix the problem by making the IP address optional.
Comment 1 David Greenhouse 2006-04-15 11:03:13 UTC 
i386 FC5 now using spamassassin-3.1.1-1.fc5 - same issue.

Now at line 1232 in Received.pm, same fix.
Comment 2 Justin Mason 2006-04-15 14:59:06 UTC 
yep, verified.   it's harmless, of course, but would be useful to fix.
Committed revision 394297 in svn trunk, aiming this patch for 3.1.2...
Comment 3 Justin Mason 2006-04-15 14:59:40 UTC 
Created attachment 3473 [details]
fix for b310
Comment 4 Sidney Markowitz 2006-04-16 12:53:30 UTC 
+1
Comment 5 Daryl C. W. O'Shea 2006-04-25 03:13:31 UTC 
+1
Comment 6 Theo Van Dinter 2006-05-02 03:33:24 UTC 
Sending        lib/Mail/SpamAssassin/Message/Metadata/Received.pm
Transmitting file data .
Committed revision 398790.