Bug 4953 - [review] Loaded, but unused: Carp.pm, Config.pm
Summary: [review] Loaded, but unused: Carp.pm, Config.pm
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All other
: P2 trivial
Target Milestone: 3.1.4
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: go
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-14 14:27 UTC by Radoslaw Zielinski
Modified: 2006-07-12 02:47 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Patch for svn trunk. patch None Radoslaw Zielinski [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Radoslaw Zielinski 2006-06-14 14:27:08 UTC 
Carp.pm is loaded, but not used anywhere but spamd (Carp::cluck).
Config.pm is loaded but not used in spamd.

Trivial patch for svn trunk attached, can be hand-applied to 3.1
branch as well.  (I have sent CLA on 25th may 2006).

(Is Bugzilla the right place to register minor fixes like this one?)
Comment 1 Radoslaw Zielinski 2006-06-14 14:28:02 UTC 
Created attachment 3551 [details]
Patch for svn trunk.
Comment 2 Justin Mason 2006-06-20 14:07:47 UTC 
'(Is Bugzilla the right place to register minor fixes like this one?)'

yep!  

(a) each bug entry is a ready-made "discussion thread", esp since it cc's dev@
anyway, and a permalink for discussion tracking which can be pointed to.

(b) everyone gets to read why each change happens (since BZ cc's dev@).

(b) it allows us to make sure the changes don't "slip through the cracks".

applied to trunk.
Comment 3 Justin Mason 2006-06-20 14:08:24 UTC 
marking FIXED; I don't think we urgently need to apply to 3.1.x as well
Comment 4 Theo Van Dinter 2006-06-20 18:00:39 UTC 
(In reply to comment #3)
> marking FIXED; I don't think we urgently need to apply to 3.1.x as well

I agree that it doesn't urgently need to be applied, but I'd like to have it
applied for a future 3.1 release.  :)

+1 btw (the patch needs a little work to apply to 3.1, but...)
Comment 5 Justin Mason 2006-06-20 18:19:52 UTC 
+1 in that case.
Comment 6 Daryl C. W. O'Shea 2006-07-11 23:27:20 UTC 
(In reply to comment #4)
> +1 btw (the patch needs a little work to apply to 3.1, but...)

what the heck, +1
Comment 7 Justin Mason 2006-07-12 09:47:20 UTC 
applied:

Sending        lib/Mail/SpamAssassin/Conf/LDAP.pm
Sending        lib/Mail/SpamAssassin/Conf/Parser.pm
Sending        lib/Mail/SpamAssassin/Conf/SQL.pm
Sending        lib/Mail/SpamAssassin/Dns.pm
Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending        lib/Mail/SpamAssassin/Reporter.pm
Sending        spamd/spamd.raw
Transmitting file data .......
Committed revision 421209.