Bug 5031 - Can't check Archive::Tar package version containing underscore
Summary: Can't check Archive::Tar package version containing underscore
Status: RESOLVED WORKSFORME
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: sa-update (show other bugs)
Version: 3.1.4
Hardware: All All
: P5 minor
Target Milestone: 3.1.5
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-03 19:48 UTC by Nick Radov
Modified: 2010-07-19 15:43 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Radov 2006-08-03 19:48:08 UTC 
I have Archive::Tar package version 1.26_01 installed. When sa-update runs it 
reports this error.

Argument "1.26_01" isn't numeric in subroutine entry at C:\Perl\bin\sa-update 
line 90.
Comment 1 Theo Van Dinter 2006-08-03 20:31:26 UTC 
I'll leave this open for other comments, but IMO this is a bug in Archive::Tar.
 Specifically, reading the perlmodstyle POD:

       If you want to release a ’beta’ or ’alpha’ version of a module but don’t
want CPAN.pm to list it as     most recent use an ’_’ after the regular version
number followed by at least 2 digits, eg. 1.20_01.
       If you do this, the following idiom is recommended:

         $VERSION = "1.12_01";
         $XS_VERSION = $VERSION; # only needed if you have XS code
         $VERSION = eval $VERSION;

       With that trick MakeMaker will only read the first line and thus read the
underscore, while the perl
       interpreter will evaluate the $VERSION and convert the string into a
number. Later operations that
       treat $VERSION as a number will then be able to do so without provoking a
warning about $VERSION not
       being a number.



Our call to require a certain version of Archive::Tar is a standard/valid one:

use Archive::Tar 1.23;


So I'm inclined to close as WFM.
Comment 2 Theo Van Dinter 2006-08-20 18:22:41 UTC 
Since I haven't seen any other comments, I'm closing this as wfm.
Comment 3 Daniel Lemke 2010-03-18 15:26:23 UTC 
Ok that bug is a bit outdated but I got the same warning while running SA with Perl 5.8.8 under windows.

I installed the current version (1.58) from CPAN and the warning disappeared. Just mentioning because of the "worksforme", can be set to fixed, I guess.
Comment 4 Ned Slider 2010-07-13 15:11:00 UTC 
Cropped up again on current RHEL5:

https://bugzilla.redhat.com/show_bug.cgi?id=612879
Comment 5 Jonathan 2010-07-19 14:11:44 UTC 
(In reply to comment #4)
> Cropped up again on current RHEL5:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=612879

Please reopen (I do not have sufficient privileges) as RedHat, CentOS and SME Server users are suffering this issue:

CentOS: http://bugs.centos.org/view.php?id=4438
RedHat: https://bugzilla.redhat.com/show_bug.cgi?id=612879
SME Server: http://bugs.contribs.org/show_bug.cgi?id=6135

RedHat bugzilla lists an easy fix in https://bugzilla.redhat.com/show_bug.cgi?id=612879#c8 I suggest to apply that.
Comment 6 Jonathan 2010-07-19 14:13:09 UTC 
(In reply to comment #5)
> RedHat bugzilla lists an easy fix in
> https://bugzilla.redhat.com/show_bug.cgi?id=612879#c8 I suggest to apply that.

Oops, that fix is not against your source.
Comment 7 Karsten Bräckelmann 2010-07-19 15:43:15 UTC 
Just to clarify: It is not, and never has been, a bug with SA. See comment 1, even linked from the recent RH bug report. Thus, this very report will not be reopened, neither set to fixed, because there is nothing to fix on our end. :)

Links and pointers to other bug trackers added here for reference welcome. Also of course notes about the issue being fixed in $distro or upstream.