Bug 5077 - [review] SPF plugin defaults to SOFTFAIL when DNS queries timeout
Summary: [review] SPF plugin defaults to SOFTFAIL when DNS queries timeout
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 3.1.6
Assignee: Daryl C. W. O'Shea
URL:
Whiteboard: ready to commit
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-01 03:54 UTC by Daryl C. W. O'Shea
Modified: 2006-10-03 15:57 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
patch patch None Daryl C. W. O'Shea [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daryl C. W. O'Shea 2006-09-01 03:54:00 UTC 
The SPF plugin defaults to SOFTFAIL when DNS queries timeout causing FPs for
domains that don't even publish SPF records, not good!

This applies to both the envelope checks and the silly HELO checks.  Notice that
when this happens you'll see no reason logged for the failure in the report.

	*  1.4 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
	*      [SPF failed: ]
Comment 1 Daryl C. W. O'Shea 2006-09-07 04:44:10 UTC 
Created attachment 3688 [details]
patch
Comment 2 Daryl C. W. O'Shea 2006-09-07 04:45:39 UTC 
[dos@FC5-VPC trunk]$ svn ci -m "bug 5077: fix false SPF_SOFTFAIL's when SPF
queries timeout"
Sending        lib/Mail/SpamAssassin/Plugin/SPF.pm
Transmitting file data .
Committed revision 440974.
Comment 3 Justin Mason 2006-09-08 13:57:25 UTC 
+1
Comment 4 Sidney Markowitz 2006-10-03 15:40:01 UTC 
+1
Comment 5 Daryl C. W. O'Shea 2006-10-03 15:57:48 UTC 
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5077: fix false SPF_SOFTFAIL's when SPF
queries timeout"
Sending        lib/Mail/SpamAssassin/Plugin/SPF.pm
Transmitting file data .
Committed revision 452668.