Bug 521 - remarks regarding URI_IS_POUND
Summary: remarks regarding URI_IS_POUND
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 2.31
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-07 11:42 UTC by Adrian Bunk
Modified: 2002-07-29 00:41 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Bunk 2002-07-07 11:42:11 UTC 
uri URI_IS_POUND        m{\#$}
describe URI_IS_POUND   Filename is just a '\#'; probably a JS trick


This rule matches the line

  trider-g7:~# ksymoops
  
and I'm not sure whether this is intended.


And the description doesn't match the real behavior, it does a
check for "file name ends with a '#'" or so (the "\" is wrong), not a:

SPAM: URI_IS_POUND       (2.0 points)  URI: Filename is just a '\#'; probably a
JS trick
Comment 1 Matthew Cline 2002-07-08 20:23:20 UTC 
Hmmmm, the Perl regular expression which extracts bare URLs (ones not inside
an HTML tag) must be picking up "trider-g7:~#".  Can URI protocol names
contain a "-"?  If not, then a separate bug should be filed about that.

As for the "\" in the comment, that's there because otherwise the "#"
will be interpreted as the beggining of a comment.  I guess Conf.pm needs to
be fixed to take care of that.
Comment 2 Adrian Bunk 2002-07-09 00:21:44 UTC 
Accourding to RFC 2396 it seems a "-" is allowed...


Regarding the description of URI_IS_POUND:

20_uri_tests.cf:describe URI_IS_POUND   Filename is just a '\#'; probably a JSrick
                                                           ^^^^

It's escaped twice, IOW the right solution should be instead of
  '\#'
either a
  '#'
or a
  \#
Comment 3 Justin Mason 2002-07-29 08:41:36 UTC 
fixed