Bug 5236 - Support Mail::SPF replacement for Mail::SPF::Query
Summary: Support Mail::SPF replacement for Mail::SPF::Query
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 3.2.0
Assignee: Daryl C. W. O'Shea
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-09 15:16 UTC by Daryl C. W. O'Shea
Modified: 2006-12-12 18:27 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daryl C. W. O'Shea 2006-12-09 15:16:21 UTC 
Julian has a pre release out for Mail::SPF which is supposed to more accurately
reflect their experimental RFC and, I imagine, eliminates the historical
oddities present in Mail::SPF::Query.

I'd like to have support for both Mail::SPF and Mail::SPF::Query in 3.2.
Comment 1 Justin Mason 2006-12-11 11:01:42 UTC 
link: http://search.cpan.org/dist/Mail-SPF/lib/Mail/SPF.pm

yeah, looks good.  do you really think we need to support both, though?
given that it's a pretty expensive network test, I'd prefer to go
with whichever one will be better-supported and more standardised.
Comment 2 Justin Mason 2006-12-11 11:03:27 UTC 
on the other hand, if you mean "support both" as in "if Mail::SPF is installed,
use that, otherwise fall back and attempt to use Mail::SPF::Query" -- +1 to that.
Comment 3 Daryl C. W. O'Shea 2006-12-11 11:13:23 UTC 
(In reply to comment #2)
> on the other hand, if you mean "support both" as in "if Mail::SPF is installed,
> use that, otherwise fall back and attempt to use Mail::SPF::Query" -- +1 to that.

Yeah, of course, doing otherwise would be, well, insane. ;)
Comment 4 Doc Schneider 2006-12-11 11:22:36 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > on the other hand, if you mean "support both" as in "if Mail::SPF is installed,
> > use that, otherwise fall back and attempt to use Mail::SPF::Query" -- +1 to
that.
> 
> Yeah, of course, doing otherwise would be, well, insane. ;)

I'm +1 on the insane part! 8*)) also sounds like a good solution to me.
Comment 5 Justin Mason 2006-12-12 12:40:19 UTC 
moving RFEs and low-priority stuff to 3.3.0 target
Comment 6 Fred T 2006-12-12 15:05:04 UTC 
Just thought I'd peep in here, if you want this aimed at 3.2, you need to re-
target now ;)
Comment 7 Daryl C. W. O'Shea 2006-12-12 18:27:22 UTC 
Yeah, 3.2:

Sending        INSTALL
Sending        lib/Mail/SpamAssassin/DnsResolver.pm
Sending        lib/Mail/SpamAssassin/Plugin/SPF.pm
Sending        t/spf.t
Transmitting file data ....
Committed revision 486461.
[dos@FC5-VPC trunk]$