Bug 5268 - Handle Hex Urls
Summary: Handle Hex Urls
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P2 normal
Target Milestone: 3.2.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: pre-mass-check
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-02 08:59 UTC by Stuart Johnston
Modified: 2007-01-24 05:01 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Johnston 2007-01-02 08:59:59 UTC 
Hexadecimal urls should be converted to the ip address so that they can be
looked-up in SURBL/URIBL.  The rule URI_HEX, should perhaps be updated to
include the dotted-quad form.

Example:

http://0xdd.0x6.0xf.0x8a/ws/eBayISAPI.dll
Comment 1 Theo Van Dinter 2007-01-23 16:17:35 UTC 
does that work on any MUA?

SA handles most of the hex obfuscation techniques, except this one doesn't have
leading 0's so SA doesn't see it as valid hex.  it also doesn't work in any
browser I've looked at.

w/ leading 0s:

[23230] dbg: uri: html uri found, http://0xdd.0x06.0x0f.0x8a/ws/eBayISAPI.dll
[23230] dbg: uri: cleaned html uri, http://0xdd.0x06.0x0f.0x8a/ws/eBayISAPI.dll
[23230] dbg: uri: cleaned html uri, http://221.6.15.138/ws/eBayISAPI.dll
[23230] dbg: uri: html domain, 221.6.15.138

w/out:
[23249] dbg: uri: html uri found, http://0xdd.0x6.0xf.0x8a/ws/eBayISAPI.dll
[23249] dbg: uri: cleaned html uri, http://0xdd.0x6.0xf.0x8a/ws/eBayISAPI.dll
Comment 2 Theo Van Dinter 2007-01-23 16:25:44 UTC 
I could be convinced that hex w/ single digit should be dealt with so moving to 3.2.
Comment 3 Justin Mason 2007-01-24 04:35:00 UTC 
This would need to happen before mass-checks start tomorrow!
Comment 4 Justin Mason 2007-01-24 05:01:52 UTC 
ok, I could see this being useful ;)  so I did it:

: jm 174...; svn commit -m "bug 5268: support single-digit hexadecimal numbers
in the host part of URIs" t/uri.t lib/Mail/SpamAssassin/Util.pm 
Sending        lib/Mail/SpamAssassin/Util.pm
Sending        t/uri.t
Transmitting file data ..
Committed revision 499388.