Bug 5279 - Invalid continuation in Makefile.PL
Summary: Invalid continuation in Makefile.PL
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: 3.1.7
Hardware: HP HP-UX
: P5 normal
Target Milestone: 3.1.8
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-05 11:08 UTC by Doug Claar
Modified: 2007-01-05 13:11 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Claar 2007-01-05 11:08:39 UTC 
The structure:

    'PM_FILTER' => '$(PREPROCESS) -Mconditional -Mvars -DVERSION="$(VERSION)" \
        -DPREFIX="$(I_PREFIX)" \
        -DDEF_RULES_DIR="$(I_DATADIR)" \
        -DLOCAL_RULES_DIR="$(I_CONFDIR)" \
        -DLOCAL_STATE_DIR="$(I_LOCALSTATEDIR)" \
        ',

In Makefile.PL produces the structure:
PM_FILTER = $(PREPROCESS) -Mconditional -Mvars -DVERSION="$(VERSION)" \
        -DPREFIX="$(I_PREFIX)" \
        -DDEF_RULES_DIR="$(I_DATADIR)" \
        -DLOCAL_RULES_DIR="$(I_CONFDIR)" \
        -DLOCAL_STATE_DIR="$(I_LOCALSTATEDIR)" \
<tab>

In Makefile. In many versions of make, including the one in hp-ux, this causes
everything up until the next blank line to be part of the PM_FILTER macro.

This presents as an odd build failure:

/opt/perl/bin/perl build/preprocessor -Mconditional -Mvars -DVERSION="3.001007"
 -DPREFIX="/opt/perl"  -DDEF_RULES_DIR="/opt/perl/share/spamassassin" 
-DLOCAL_RULES_DIR="/etc/opt/mail/spamassassin" 
-DLOCAL_STATE_DIR="/var/opt/spamassassin"  # Handy lists of source code files:
<lib/Mail/SpamAssassin/AutoWhitelist.pm >blib/lib/Mail/SpamAssassin/AutoWhitelist.pm
AutoSplit: Can't open blib/lib/Mail/SpamAssassin/AutoWhitelist.pm: No such file
or directory
*** Error exit code 2

Stop.

This was reported in Bug 5084, which was closed "WONTFIX", apparently because
the submitter had a workaround?

The fix is easy: Remove the last "\" and the tab on the next line:

    'PM_FILTER' => '$(PREPROCESS) -Mconditional -Mvars -DVERSION="$(VERSION)" \
        -DPREFIX="$(I_PREFIX)" \
        -DDEF_RULES_DIR="$(I_DATADIR)" \
        -DLOCAL_RULES_DIR="$(I_CONFDIR)" \
        -DLOCAL_STATE_DIR="$(I_LOCALSTATEDIR)"',

==Doug Claar
Comment 1 Theo Van Dinter 2007-01-05 13:11:03 UTC 
Hrm.  Not sure why that's in there, but it does look suspicious, so I removed it:

3.2:
Sending        Makefile.PL
Transmitting file data .
Committed revision 493191.

3.1:
Sending        Makefile.PL
Transmitting file data .
Committed revision 493192.

:)