Bug 5298 - DKIM plugin - no longer needs Crypt::OpenSSL::Bignum
Summary: DKIM plugin - no longer needs Crypt::OpenSSL::Bignum
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: 3.1.7
Hardware: Other other
: P5 normal
Target Milestone: 3.2.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-17 13:56 UTC by Jason Long
Modified: 2007-01-22 06:43 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
update requires for Plugin::DKIM patch None Jason Long [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Long 2007-01-17 13:56:41 UTC 
Version 0.18 no longer depends on Crypt::OpenSSL::Bignum, so it can be removed
from the requirements list in Mail::SpamAssassin::Plugin::DKIM.

(See attached patch.)

My apologies in advance if this isn't the correct forum for this sort of patch.
Comment 1 Jason Long 2007-01-17 13:58:04 UTC 
Created attachment 3829 [details]
update requires for Plugin::DKIM
Comment 2 Justin Mason 2007-01-18 08:03:15 UTC 
we can just drop the Crypt::OpenSSL::Bignum reference, without requiring 0.18
explicitly, right?
Comment 3 Jason Long 2007-01-18 08:44:55 UTC 
Yeah remove the 0.18, I was thinking that would specify a minimum version number
for Mail::DKIM, but I guess 'require' doesn't work that way.

Versions of the Mail::DKIM module older than 0.18 required Crypt::OpenSSL::Bignum.

Versions 0.18 and greater do not require Crypt::OpenSSL::Bignum.
Comment 4 Justin Mason 2007-01-22 06:43:26 UTC 
ok, done:

: jm 31...; svn commit -m "bug 5298: Mail::DKIM 0.18 apparently no longer needs
Crypt::OpenSSL::Bignum, so remove it from the requires list in our plugin and
let Mail::DKIM sort it out internally" lib/Mail/SpamAssassin/Plugin/DKIM.pm
Sending        lib/Mail/SpamAssassin/Plugin/DKIM.pm
Transmitting file data .
Committed revision 498626.