Bug 5367 - t/spamd_hup.t fails a lot
Summary: t/spamd_hup.t fails a lot
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P3 normal
Target Milestone: 3.2.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-06 09:34 UTC by Justin Mason
Modified: 2007-03-14 13:08 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2007-03-06 09:34:17 UTC 
this test has been failing intermittently on the zone, and in my checkout.
We should probably try and figure out why before 3.2.0 release-- hopefully it's
just a buggy test, rather than a race in spamd.
Comment 1 Justin Mason 2007-03-14 08:40:15 UTC 
some more data points:

- it's not just spamd_hup.t, it's also spamd_kill_restart.t and
spamd_kill_restart_rr.t.  all 3 tests share a lot of logic and code.  I suspect
race conditions in test code.

- it's not very frequent -- there are about 5-10 spamd_hup.t failures in 640
buildbot test suite runs.  so quite rare.

I think it's a race condition, where the test script spots a new pid-file and
goes to read it before the spamd has _written_ any spamd PID into it.  I think I
may have fixed it in trunk now -- let's see how it goes.
Comment 2 Justin Mason 2007-03-14 13:08:48 UTC 
ok, that seems to have helped...