Bug 5432 - [review] win32 build should default to not building spamc
Summary: [review] win32 build should default to not building spamc
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 minor
Target Milestone: 3.2.1
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-23 04:29 UTC by Justin Mason
Modified: 2007-06-03 02:52 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
fix patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2007-04-23 04:29:40 UTC 
seeing as most win32 installs will not have CL.EXE available, and since many
win32 users may not be using spamc anyway, it seems silly that use a default of
"y" for build_spamc:

Build spamc.exe (environment must be set up for C compiler)? (y/n) [y]

IMO this should default to 'n'.

not a showstopper, this can wait for 3.2.1 (or even 3.3.0).
Comment 1 Justin Mason 2007-05-03 04:58:15 UTC 
Created attachment 3933 [details]
fix

here's the patch -- it's pretty simple.  please review...
Comment 2 Daryl C. W. O'Shea 2007-05-23 23:59:49 UTC 
sure +1
Comment 3 Sidney Markowitz 2007-06-03 01:13:11 UTC 
+1
Comment 4 Sidney Markowitz 2007-06-03 02:52:58 UTC 
Committed to trunk revision 543867.

Committed to 3.2 branch revision 543868.