Bug 5527 - [review] Patch to parse AOL WebMail received headers to improve accuracy.
Summary: [review] Patch to parse AOL WebMail received headers to improve accuracy.
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 3.2.1
Hardware: All All
: P3 enhancement
Target Milestone: 3.2.4
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: can be commited
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-19 09:52 UTC by Steve Freegard
Modified: 2007-10-17 06:49 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Proposed patch to add AOL WebMail received header support patch None Steve Freegard [NoCLA]
Example message to test the patch text/plain None Steve Freegard [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Freegard 2007-06-19 09:52:15 UTC 
Currently SpamAssassin doesn't recognize AOL WebMail received headers.  The
patch attached to this bug adds support for these received headers in
M::SA::Mail::Metadata::Received.

I have attached a sample message which on my system scores 2.2 without the patch
and 7.5 with the patch applied (the extra score is from DNSBL hits).
Comment 1 Steve Freegard 2007-06-19 09:53:09 UTC 
Created attachment 4000 [details]
Proposed patch to add AOL WebMail received header support
Comment 2 Steve Freegard 2007-06-19 09:53:58 UTC 
Created attachment 4001 [details]
Example message to test the patch
Comment 3 Justin Mason 2007-07-30 05:47:59 UTC 
looks good to me.  +1

applied to trunk:

: jm 96...; svn commit -m "bug 5527: parse AOL WebMail Received HTTP-handover
headers, thanks to Steve Freegard <steve.freegard at fsl.com>"
lib/Mail/SpamAssassin/Message/Metadata/Received.pm
Sending        lib/Mail/SpamAssassin/Message/Metadata/Received.pm
Transmitting file data .
Committed revision 560952.
Comment 4 Daryl C. W. O'Shea 2007-08-07 10:27:05 UTC 
Sure, +1.
Comment 5 Justin Mason 2007-08-12 06:38:59 UTC 
3.2.3 was released without these fixed, moving to 3.2.3
Comment 6 Doc Schneider 2007-10-11 14:54:44 UTC 
+1
Comment 7 Justin Mason 2007-10-17 06:49:01 UTC 
committed to 3.2.x:

Sending        lib/Mail/SpamAssassin/Message/Metadata/Received.pm
Transmitting file data .
Committed revision 585506.