Bug 5534 - [review] sa-compile 'ISO C90 forbids mixed declarations and code' warnings
Summary: [review] sa-compile 'ISO C90 forbids mixed declarations and code' warnings
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: sa-compile (show other bugs)
Version: 3.2.1
Hardware: PC Linux
: P5 minor
Target Milestone: 3.2.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-21 10:31 UTC by Nigel Frankcom
Modified: 2007-07-04 13:04 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
fix patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nigel Frankcom 2007-06-21 10:31:39 UTC 
Using Perl 5.8.8 on CentOS 4.5 when running sa-compile I get the following:
body_0.xs: In function
`XS_Mail__SpamAssassin__CompiledRegexps__body_0_scan':
body_0.xs:43: warning: ISO C90 forbids mixed declarations and code
body_0.xs:51: warning: ISO C90 forbids mixed declarations and code
body_0.xs:59: warning: ISO C90 forbids mixed declarations and code
body_0.xs:67: warning: ISO C90 forbids mixed declarations and code
body_0.xs:75: warning: ISO C90 forbids mixed declarations and code
body_0.xs:83: warning: ISO C90 forbids mixed declarations and code
body_0.xs:91: warning: ISO C90 forbids mixed declarations and code
body_0.xs:99: warning: ISO C90 forbids mixed declarations and code
body_0.xs:107: warning: ISO C90 forbids mixed declarations and code
Comment 1 Justin Mason 2007-06-22 05:52:48 UTC 
Created attachment 4010 [details]
fix
Comment 2 Justin Mason 2007-06-22 05:55:20 UTC 
applied to trunk:

: jm 83...; svn commit -m "bug 5534: fix annoying 'ISO C90 forbids mixed
declarations and code' warnings from sa-compile, caused by extern declarations
inside functions" sa-compile.raw
Sending        sa-compile.raw
Transmitting file data .
Committed revision 549808.
Comment 3 Sidney Markowitz 2007-06-24 01:48:05 UTC 
+1 for 3.2 branch
Comment 4 Daryl C. W. O'Shea 2007-07-04 12:06:27 UTC 
+1
Comment 5 Sidney Markowitz 2007-07-04 13:04:59 UTC 
Committed to branch 3.2 revision 553317.