Bug 5544 - [review] ALL_TRUSTED is nonmutable
Summary: [review] ALL_TRUSTED is nonmutable
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.2.1
Hardware: Other other
: P5 minor
Target Milestone: 3.2.3
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: needs 2 votes for 3.2
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-03 05:26 UTC by Justin Mason
Modified: 2007-08-07 08:22 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
fix patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2007-07-03 05:26:44 UTC 
as discovered during bug 5270, ALL_TRUSTED is marked as mutable:

ifplugin Mail::SpamAssassin::Plugin::RelayEval
# <gen:mutable>
score ALL_TRUSTED -1.360 -1.440 -1.665 -1.800
...
# </gen:mutable>

Duncan noted in http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5270#c37
that it's not actually treated as mutable however:

'FWIW, ALL_TRUSTED is in a <gen:mutable> section, but immutable by
score-ranges-for-freqs due to tflags userconf.'

I think we should explicitly mark it as nonmutable, and move it out of the
mutable section of 50_scores.cf.
Comment 1 Justin Mason 2007-07-30 06:19:40 UTC 
Created attachment 4072 [details]
fix

here's the fix. applied to trunk:

: jm 89...; svn commit -m "bug 5544: ALL_TRUSTED is immutable, mark this
explicitly by putting it in an immutable section" rules/50_scores.cf
Sending        rules/50_scores.cf
Transmitting file data .
Committed revision 560972.
Comment 2 Matt Kettler 2007-07-30 16:00:38 UTC 
+1
Comment 3 Justin Mason 2007-08-07 08:22:54 UTC 
applied to 3.2.x:

: jm 340...; svn commit -m "bug 5544: ALL_TRUSTED is immutable, mark this
: jm 341... >>; explicitly by putting it in an immutable section" rules/50_scores.cf
Sending        rules/50_scores.cf
Transmitting file data .
Committed revision 563521.