Bug 558 - LOW_PAYMENT Upgrade
Summary: LOW_PAYMENT Upgrade
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: Daniel Quinlan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-17 19:05 UTC by Marc Perkel
Modified: 2002-07-21 02:14 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Perkel 2002-07-17 19:05:32 UTC 
Some of the rules I suggested got added in a way that doesn't work as well as I
originally intended. Whoever added them put \b at the beginning and end of all
of them, which is fine in many cases, but not fine in others. Anyhow - here's an
example where it broke the effectiveness of the rule. The \b makes the plural
not match - in this case "payments".

Current:

body LOW_PAYMENT	        /\b(?:reduce|low).{0.12} payment\b/i
describe LOW_PAYMENT		Lower Monthly Payment

Better:

body LOW_PAYMENT	        /\b(?:reduce|low).{0.12} payment/i
describe LOW_PAYMENT		Lower Monthly Payment

Or:

body LOW_PAYMENT	        /\b(?:reduce|low).{0.12} payment(?:s)?\b/i
describe LOW_PAYMENT		Lower Monthly Payment
Comment 1 Daniel Quinlan 2002-07-17 19:38:27 UTC 
Subject: Re: [SAdev]  New: LOW_PAYMENT Upgrade

> body LOW_PAYMENT	        /\b(?:reduce|low).{0.12} payment(?:s)?\b/i
> describe LOW_PAYMENT		Lower Monthly Payment

1. the grouping for the final "s" is unnecessary
2. the {0.12} should be {0,12}
3. replace the space before payments with a \b
4. change the final "e" in reduce to "[ei]" to match "reducing"

  body LOW_PAYMENT	        /\b(?:reduc[ei]|low).{0,12}\bpayments?\b/i
  describe LOW_PAYMENT		Lower Payments

Dan
Comment 2 Daniel Quinlan 2002-07-18 00:17:22 UTC 
assigning to me
Comment 3 Daniel Quinlan 2002-07-21 10:14:44 UTC 
done