SA Bugzilla – Bug 5908
fix Makefile.PL to evade stupid smoke testers
Last modified: 2008-08-13 14:53:07 UTC
every couple of days, I get at least one of these: Subject: FAIL Mail-SpamAssassin-3.2.4 darwin-2level 7.9.0 Date: Sun, 11 May 2008 18:50:52 +0100 To: cpan-testers@perl.org Cc: JMASON@cpan.org This distribution has been tested as part of the cpan-testers effort to test as many new uploads to CPAN as possible. See http://testers.cpan.org/ Please cc any replies to cpan-testers@perl.org to keep other test volunteers informed and to prevent any duplicate effort. -- Dear Justin Mason, This is a computer-generated report for Mail-SpamAssassin-3.2.4 on perl 5.8.1, created by CPAN-Reporter-1.13. Thank you for uploading your work to CPAN. However, there was a problem testing your distribution. If you think this report is invalid, please consult the CPAN Testers Wiki for suggestions on how to avoid getting FAIL reports for missing library or binary dependencies, unsupported operating systems, and so on: http://cpantest.grango.org/wiki/CPANAuthorNotes Sections of this report: * Tester comments * Program output * Prerequisites * Environment and other context ------------------------------ TESTER COMMENTS ------------------------------ Additional comments from tester: this report is from an automated smoke testing program and was not reviewed by a human for accuracy ------------------------------ PROGRAM OUTPUT ------------------------------ Output from '/Users/jj/perl/perl-5.8.1/bin/perl Makefile.PL': What email address or URL should be used in the suspected-spam report text for users who want more information on your filter installation? (In particular, ISPs should change this to a local Postmaster contact) default text: [the administrator of that system] the administrator of that system ERROR: the required Digest::SHA1 module is not installed. at lib/Mail/SpamAssassin/Util/DependencyInfo.pm line 294. ERROR: the required HTML::Parser (version 3.43) module is not installed. at lib/Mail/SpamAssassin/Util/DependencyInfo.pm line 294. ERROR: the required Net::DNS (version 0.34) module is not installed. at lib/Mail/SpamAssassin/Util/DependencyInfo.pm line 294. note the ERRORs. however the smoke testers never bother reading that bit before hitting "yes, send this fail report". grr. there may be some way to fix our Makefile.PL to enforce this. if we don't "exit 1" when a REQUIRED module is missing, we should be doing that at least.
'if we don't "exit 1" when a REQUIRED module is missing, we should be doing that at least.' turns out we _do_ do that, but it's the wrong thing to do; http://cpantest.grango.org/wiki/CPANAuthorNotes says we should instead exit with a status of 0, but without creating Makefile. That will inhibit the cpan-tester errors, but will still be obviously a failure to other users. I've added a META.yml, too. I think that covers it now... : jm 99...; svn commit -m "bug 5908: exit 0 instead of 1 if a required module is missing; this will avoid broken cpan-tester mails" Sending Makefile.PL Transmitting file data . Committed revision 685690.