Bug 6013 - URIBLs should support util_rb_3tld
Summary: URIBLs should support util_rb_3tld
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other All
: P3 enhancement
Target Milestone: 3.3.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-06 03:22 UTC by Henrik Krohns
Modified: 2008-11-24 08:17 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
fix applied to trunk patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Krohns 2008-11-06 03:22:50 UTC 
Now especially that spaces.live.com spam is around, there seems to be an illogical function in SA. Why is domain splitted from URIs? I can understand that for querying for NSs, but it makes no sense for direct URIBL query.

I fixing this requires modifying of uri_to_domain to return both splitted and full hostname? And using the full hostname to launch bl queries.
Comment 1 Henrik Krohns 2008-11-06 07:20:50 UTC 
Ok I didn't know that all that is for saving DNS queries and URIBL won't support wildcards. Discussion can be found on uribl-discuss.

I guess the only quick fix is to implement uri_rb_3tld.
Comment 2 mouss 2008-11-06 12:21:17 UTC 
or uri_full (otherwise, next spammer trick will force a uri_rb_4tld and so on).
Comment 3 Justin Mason 2008-11-24 08:17:22 UTC 
Created attachment 4396 [details]
fix applied to trunk

fixed, adding to trunk...

: 69...; svn commit -m "bug 6013: add 'util_rb_3tld', allowing 3-level TLDs to be listed in URIBLs and allowing new 3TLDs to be added from rule updates"
Sending        lib/Mail/SpamAssassin/Conf.pm
Sending        lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm
Sending        t/uri.t
Transmitting file data ...
Committed revision 720217.
Comment 4 Justin Mason 2008-11-24 08:17:40 UTC 
closing