Bug 6128 - RCVD_IN_DNSWL rules are ignored
Summary: RCVD_IN_DNSWL rules are ignored
Status: RESOLVED WORKSFORME
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.2.5
Hardware: All All
: P5 major
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-08 19:07 UTC by Nick Forde
Modified: 2009-06-09 20:26 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Forde 2009-06-08 19:07:01 UTC 
The file 72_active.cf from updates.spamassassin.org is incorrect, causing the 3 RCVD_IN_DNSWL rules to be ignored.

The 3 rules are -
RCVD_IN_DNSWL_HI
RCVD_IN_DNSWL_LOW
RCVD_IN_DNSWL_MED)

The following lines are currently AFTER the 3 sub-rules, however they need to be BEFORE the 3 DNSWL sub-rules -

ifplugin Mail::SpamAssassin::Plugin::DNSEval
header  __RCVD_IN_DNSWL         eval:check_rbl('dnswl-firsttrusted', 'list.dnswl.org.')
tflags  __RCVD_IN_DNSWL         nice net
endif


Currently the above lines are AFTER the 3 DNSWL sub-rules  which means all of these rules are ignored.
Comment 1 Nick Forde 2009-06-08 19:19:18 UTC 
This is obviously related to the comments on http://www.dnswl.org/tech#spamassassin -

"SpamAssassin Configuration

Please note that as of version 3.2.0, the rules below are included in the SpamAssassin default package. The distribution package for 3.2.0 had a bug that prevented the rules from actually firing (the __RCVD_IN_DNSWL part was missing), but this has been fixed in subsequent versions."

Obviously the 'this has been fixed' is wrong, as those lines were pasted in the wrong position in 72_active.cf
Comment 2 Nick Forde 2009-06-08 19:33:56 UTC 
Update - This bug is related to the incorrect resolution of bug 5450 in June 2007...

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5450
Comment 3 Karsten Bräckelmann 2009-06-09 06:38:26 UTC 
(In reply to comment #0)
> The file 72_active.cf from updates.spamassassin.org is incorrect, causing the 3
> RCVD_IN_DNSWL rules to be ignored.

While this indeed might strike one as odd, the order obviously is not important with properly registering those eval rules.

WORKSFORME and other users, as can be observed on the users list occasionally. ;)
Comment 4 Nick Forde 2009-06-09 20:26:13 UTC 
Sorry, I've retested and it's working with the original version of 72_active.cf

The rules weren't working when I originally tested them yesterday but it was probably just a temporary lookup timeout issue.

Thanks for your quick response anyway.