Bug 6208 - Trailing blanks in report
Summary: Trailing blanks in report
Status: RESOLVED INVALID
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other All
: P5 enhancement
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-20 12:48 UTC by jidanni
Modified: 2009-09-21 09:00 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jidanni 2009-09-20 12:48:54 UTC 
No big deal, but here are some trailing blanks, and even a whole empty X-Spam-Languages: that perhaps not be added if it is empty, but perhaps not.

$ find bla|xargs sed 's/ $/& <---TRAILING BLANK/;s/^/>/'
>Return-Path: <jidanni1@ps11007.dreamhostps.com>
>X-Spam-Checker-Version: SpamAssassin 3.3.0-alpha3-r816412-1717 (2009-09-18) on
>	ps11007.dreamhostps.com
>X-Spam-Flag: YES
>X-Spam-Level: ***
>X-Spam-Report:  <---TRAILING BLANK
>	*  2.0 J_NO_ME J_NO_ME
>	* -0.0 NO_RELAYS Informational: message was not relayed via SMTP
>	*  1.3 MISSING_SUBJECT Missing Subject: header
>	*  0.6 EMPTY_MESSAGE Message appears to have no textual parts and no
>	*      Subject: text
>X-Spam-Status: Yes, score=3.9 required=1.9 tests=EMPTY_MESSAGE,J_NO_ME,
>	MISSING_SUBJECT,NO_RELAYS
>X-Spam-Languages:  <---TRAILING BLANK
>X-Original-To: jidanni1@ps11007.dreamhostps.com
>Delivered-To: jidanni1@ps11007.dreamhostps.com
>Received: by ps11007.dreamhostps.com (Postfix, from userid 3369152)
>	id D9E2A2C0C3E2; Sun, 20 Sep 2009 12:40:29 -0700 (PDT)
>To: <jidanni1@ps11007.dreamhostps.com>
>X-Mailer: mail (GNU Mailutils 1.1)
>Message-Id: <20090920194029.D9E2A2C0C3E2@ps11007.dreamhostps.com>
>Date: Sun, 20 Sep 2009 12:40:29 -0700 (PDT)
>From: jidanni1@ps11007.dreamhostps.com (jidanni1)
>
Comment 1 Karsten Bräckelmann 2009-09-21 09:00:59 UTC 
The "trailing blank" is just the delimiter SA uses for all headers. The content comes after that, always and unconditional. IMHO this is perfectly fine.

The second part, adding headers defined by the add_header option, regardless of its content (that means, even if the template expands to an empty string) has been filed before and considered not a bug, AFAIR. Happens for example with the Level header for ham scoring < 1.

For the latter, I have a nice plugin hack to remove empty headers. I should publish that eventually. :)


Not a bug IMHO, closing accordingly. Thanks for the observations nonetheless.