Bug 6359 - [review] win32: posix macro not implemented - Util.pm
Summary: [review] win32: posix macro not implemented - Util.pm
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: 3.3.0
Hardware: PC Windows XP
: P1 major
Target Milestone: 3.3.1
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: ready for commit
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 14:56 UTC by Daniel Lemke
Modified: 2010-03-11 10:53 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
win32 posix macro patch application/octet-stream None Daniel Lemke [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Lemke 2010-03-02 14:56:28 UTC 
Created attachment 4687 [details]
win32 posix macro patch

The use of POSIX::SIGALRM() in Util.pm crashes spamd with the following error:

warn: spamd: Your vendor has not defined POSIX macro SIGALRM, used at C:/Perl/site/lib/Mail/SpamAssassin/Util.pm line 1564

The posix signal is used to create a unsafe signal handler for any perl version > 5.8, however this is not necessary for windows so we can use the 'old' SIG.

Patch attached
Comment 1 Mark Martinec 2010-03-02 15:37:57 UTC 
+1
Comment 2 Justin Mason 2010-03-02 17:08:37 UTC 
+1
Comment 3 Warren Togami 2010-03-11 03:17:29 UTC 
+1
Comment 4 Mark Martinec 2010-03-11 10:53:22 UTC 
trunk:
Bug 6359, no POSIX::SIGALRM on Windows, just use %SIG
Sending lib/Mail/SpamAssassin/Util.pm
Committed revision 921795.

3.3:
Bug 6359, no POSIX::SIGALRM on Windows, just use %SIG
Sending lib/Mail/SpamAssassin/Util.pm
Committed revision 921797.