Bug 6578 - [review] Move TLD regexp to RegistrarBoundaries
Summary: [review] Move TLD regexp to RegistrarBoundaries
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P4 enhancement
Target Milestone: 3.3.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 17:40 UTC by Henrik Krohns
Modified: 2011-05-04 19:46 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Move TLD regexp to RegistrarBoundaries and update FreeMail patch None Henrik Krohns [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Krohns 2011-05-01 17:40:06 UTC 
The tldsRE in PerMsgStatus.pm is more useful when defined in RegistrarBoundaries.pm. This way it can be used more generally where needed. Will update FreeMail.pm to use it. Also looking into bugs #6353 and #6061 which might potentially make use of it.
Comment 1 Henrik Krohns 2011-05-01 17:41:16 UTC 
Created attachment 4866 [details]
Move TLD regexp to RegistrarBoundaries and update FreeMail
Comment 2 Henrik Krohns 2011-05-01 17:44:19 UTC 
Committed to trunk.

Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending        lib/Mail/SpamAssassin/Plugin/FreeMail.pm
Sending        lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm
Transmitting file data ...
Committed revision 1098376.


Please vote for 3.3 ?
Comment 3 Henrik Krohns 2011-05-01 21:18:46 UTC 
Forgot "use ...RegistrarBoundaries".

Sending        PerMsgStatus.pm
Transmitting file data .
Committed revision 1098413.
Comment 4 Kevin A. McGrail 2011-05-02 13:48:44 UTC 
+1 for 3.3
Comment 5 Mark Martinec 2011-05-04 17:39:26 UTC 
Fine with me.

+1 for 3.3
Comment 6 Henrik Krohns 2011-05-04 19:46:34 UTC 
3.3 done:

Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending        lib/Mail/SpamAssassin/Plugin/FreeMail.pm
Sending        lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm
Transmitting file data ...
Committed revision 1099571.