Bug 6619 - [review] sa-update gives misleading "required" error on systems without gpg
Summary: [review] sa-update gives misleading "required" error on systems without gpg
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: sa-update (show other bugs)
Version: 3.3.2
Hardware: PC Windows 7
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 14:52 UTC by Kevin A. McGrail
Modified: 2011-06-23 18:30 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Patch to allow DependencyInfo.pm to test for required and optional binaries with a check for gpg as an optional binary & clean up gpg error message in sa-update to be more helpful patch None Kevin A. McGrail [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2011-06-16 14:52:06 UTC 
This is a follow-up on bug 6618 which was hijacked a bit.

The problem is that sa-update says gpg is required which is not 100% accurate.

I've added additions to DependencyInfo.pm to test for required/optional binaries such as gpg.

The test_version subroutine might be reinventing the wheel or doing things very
much the hard way so I would appreciate input there.

If you remove gpg, from your path (or change your path), all you have to do for a test is perl Makefile.PL CONTACT_ADDRESS=test@test.com

Would be good if you can play with the required/recommended versions and test as well with gpg in the path.

The goal of this patch is to prompt that the optional gpg binary is not installed and let the end-user know this is required for sa-update to verify the encryption signature.  

It also gives a framework built off the existing MODULES and OPTIONAL_MODULES functionality for binaries in case we need to require/test for additional binaries.

sa-update is also updated to clarify that --nogpg can be used although not recommended.
Comment 1 Kevin A. McGrail 2011-06-16 14:53:07 UTC 
Created attachment 4921 [details]
Patch to allow DependencyInfo.pm to test for required and optional binaries with a check for gpg as an optional binary & clean up gpg error message in sa-update to be more helpful
Comment 2 Kevin A. McGrail 2011-06-23 18:30:13 UTC 
 svn commit -m 'Improvement in DependencyInfo.pm for binary checks with improvements for gpg parameters in sa-update'
Sending        lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Sending        sa-update.raw
Transmitting file data ..
Committed revision 1139030.