Bug 6815 - Use of uninitialized value $origip
Summary: Use of uninitialized value $origip
Status: RESOLVED INVALID
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.3.1
Hardware: PC Linux
: P2 minor
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 04:22 UTC by Boyd Stephen Smith Jr.
Modified: 2012-07-15 21:27 UTC (History)
2 users (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Boyd Stephen Smith Jr. 2012-07-12 04:22:32 UTC
Mentioned on user's list in 2010 against 3.3.1 in Debian Lenny:
http://www.gossamer-threads.com/lists/spamassassin/users/151981

I did a quick search for "origip" in Bugzilla and only found 1 unrelated bug.  The "Possible Duplicates" listed by Bugzilla don't mention AutoWhitelist.pm.

I'm now getting the same warnings earlier today from 3.3.1 (!) in my Debian Squeeze VPS:
Use of uninitialized value $origip in concatenation (.) or string at /usr/share/perl5/Mail/SpamAssassin/AutoWhitelist.pm line 346.

It's good to know this isn't a security issue, but it was a bit concerning.  I'm hoping this bug will result in a patch landing in SVN.  With Wheezy already frozen, I expect Debian users like me will be seeing these messages for a couple more years.

I don't know if I have chosen the correct component in Bugzilla.
Comment 1 Kevin A. McGrail 2012-07-15 20:47:08 UTC
Based on the information in the thread, SVN includes a check if $result is defined as well as $origip.  

The fact that a distribution uses an older version of SpamAssassin is not a concern for the project, sorry.  

You might want to consider maintaining SA outside of your Debian package management.

Regards,
KAM
Comment 2 Boyd Stephen Smith Jr. 2012-07-15 21:22:15 UTC
Sorry for the noise.  What I saw of the thread didn't say the patch had made it into SVN, but rather than an issue should be opened so that it would be added to SVN.  Apparently the patch was included in r931606, thanks!
Comment 3 Kevin A. McGrail 2012-07-15 21:27:18 UTC
(In reply to comment #2)
> Sorry for the noise.  What I saw of the thread didn't say the patch had made
> it into SVN, but rather than an issue should be opened so that it would be
> added to SVN.  Apparently the patch was included in r931606, thanks!

No worries!