Bug 6861 - /lib/Mail/SpamAssassin/Util/DependencyInfo.pm doesn't handle test_version correctly
Summary: /lib/Mail/SpamAssassin/Util/DependencyInfo.pm doesn't handle test_version cor...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Windows 7
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 22:06 UTC by Kevin A. McGrail
Modified: 2012-11-06 02:28 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Patch to fix test_version in DependencyInfo.pm application/octet-stream None Kevin A. McGrail [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2012-11-05 22:06:52 UTC 
Created attachment 5108 [details]
Patch to fix test_version in DependencyInfo.pm

The current test_version keeps testing more minor version numbers even if a more major version has passed.  So 1.4.3 would fail tested against 1.0.6 because .3 would be less than .6.

Added short circuiting and improved the else loop to handle this better.
Comment 1 Kevin A. McGrail 2012-11-06 02:28:16 UTC 
svn commit -m 'Bug 6861 for test_version fixed for binary dependencies'
Sending        lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Transmitting file data .
Committed revision 1406030.