Bug 6891 - failure in xt/60_perlcritic.t from AsyncLoop.pm prototype
Summary: failure in xt/60_perlcritic.t from AsyncLoop.pm prototype
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Regression Tests (show other bugs)
Version: 3.4 SVN branch
Hardware: PC Windows 7
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 22:37 UTC by Kevin A. McGrail
Modified: 2013-01-18 22:45 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2013-01-18 22:37:20 UTC 
xt/60_perlcritic....................NOK 11#   Failed test 'Test::Perl::Critic for "../blib/lib/Mail/SpamAssassin/AsyncLoop.pm"'
#   at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "../blib/lib/Mail/SpamAssassin/AsyncLoop.pm":
# Subroutine prototypes used at line 87, column 1.
#   Subroutines::ProhibitSubroutinePrototypes (Severity: 5)
#     Contrary to common belief, subroutine prototypes do not enable
#     compile-time checks for proper arguments. Don't use them.

Removed the prototype on the sub domain_to_search_list and committing in a second.
Comment 1 Kevin A. McGrail 2013-01-18 22:45:24 UTC 
 svn commit -m 'bug 6891 - removed prototype on sub domain_to_search_list' lib/Mail/SpamAssassin/AsyncLoop.pm
Sending        lib/Mail/SpamAssassin/AsyncLoop.pm
Transmitting file data .
Committed revision 1435385.