Bug 7024 - check_rbl_from_host/check_rbl_from_domain/check_rbl_envfrom did not support the subtest functionality
Summary: check_rbl_from_host/check_rbl_from_domain/check_rbl_envfrom did not support t...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Windows 7
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 18:51 UTC by Kevin A. McGrail
Modified: 2014-03-20 00:25 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2014-03-18 18:51:57 UTC 
Recently added whitelist / ignore URIs to the URIBL I'm trying to develop.

Found that the code for check_rbl_from_host/check_rbl_from_domain/check_rbl_envfrom did not support the subtest functionality to limit to a specific octet.

Have fixed those stub functions to pass along the subtest information so it now works with and without subtest.  

One note, I am unsure if the subtest matching appears to be exact match not a bitwise match.  So a response of 127.0.0.12 will not match .4 and .8 (for example). Without my testing, does anyone know if do_rbl_lookup in lib/Mail/SpamAssassin/Dns.pm with the subtest will do a bitwise match?

Will submit a short patch to fix the check_rbl_from_host/from_domain/envfrom functions to implement the existing subtest code.
Comment 1 Kevin A. McGrail 2014-03-18 19:00:55 UTC 
svn commit -m 'check_rbl_from_host/check_rbl_from_domain/check_rbl_envfrom did not support the subtest functionality.  Fixed and removed has_check_rbl_from_domain as pointless now. Bug 7024'
Sending        lib/Mail/SpamAssassin/Plugin/DNSEval.pm
Transmitting file data .
Committed revision 1579012.