Bug 7255 - `dmake install` fails on windows
Summary: `dmake install` fails on windows
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: 3.4 SVN branch
Hardware: PC Windows 7
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 09:33 UTC by Martin Puppe
Modified: 2018-09-17 11:12 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
dmake-compatible Makefile application/mbox None Martin Puppe [HasCLA]
Updated patch patch None Martin Puppe [HasCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Puppe 2015-10-19 09:33:30 UTC 
Created attachment 5338 [details]
dmake-compatible Makefile

Strawberry Perl comes with dmake, and MakeMaker emits dmake-style Makefiles. `dmake install` fails with the following message:

```
"D:\Strawberry\perl\bin\perl.exe" -MFile::Copy -e "copy(qrules/local.cf, qD:\Str
awberry\perl\site/etc/mail/spamassassin/local.cf) unless -f qD:\Strawberry\perl\
site/etc/mail/spamassassin/local.cf"
Backslash found where operator expected at -e line 1, near "Strawberry\"
Backslash found where operator expected at -e line 1, near "perl\"
Backslash found where operator expected at -e line 1, near "Strawberry\"
Backslash found where operator expected at -e line 1, near "perl\"
syntax error at -e line 1, near "local."
Execution of -e aborted due to compilation errors.
dmake:  Error code 255, while making 'conf__install'
```

The problem is that braces have significance for dmake. They need to be escaped by doubling. Replacing them with brackets instead is probably more portable. See attached patch.
Comment 1 Kevin A. McGrail 2015-10-24 20:22:23 UTC 
I checked this on my linux system and it appears to work fine.  The key change is some { to {.
Comment 2 Kevin A. McGrail 2015-10-24 20:26:30 UTC 
that is { to [
Comment 3 Joe Quinn 2015-10-26 14:06:21 UTC 
Looks good when I test it as well. Committed to 4.0 and 3.4.2

Committed revision 1710600.
Committed revision 1710602.
Comment 4 Martin Puppe 2018-09-06 13:45:52 UTC 
Created attachment 5596 [details]
Updated patch

The previous patch has only been partially applied. Here is a new patch.
Comment 5 Martin Puppe 2018-09-06 13:46:34 UTC 
Reopening the bug (see above for the reason).
Comment 6 Kevin A. McGrail 2018-09-17 11:12:23 UTC 
Thanks Martin, now that 3.4.2 is out, I've added this to 3.4 and trunk

3.4:
Committed revision 1841063.
trunk:
Committed revision 1841064.