Bug 7311 - mass-check script assumes svn < 1.7
Summary: mass-check script assumes svn < 1.7
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Masses (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC FreeBSD
: P2 normal
Target Milestone: Undefined
Assignee: Dave Jones
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-21 13:29 UTC by Kevin Golding
Modified: 2018-01-07 15:26 UTC (History)
3 users (show)



Attachment Type Modified Status Actions Submitter/CLA Status
Patch to check for .svn directory in a more suitable place patch None Kevin Golding [NoCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Golding 2016-04-21 13:29:02 UTC
Created attachment 5385 [details]
Patch to check for .svn directory in a more suitable place

Since Subversion 1.7 a .svn folder is no longer created in every sub-directory. Since the mass-check script includes a check for masses/.svn it always fails and has broken the ability the run amss checks from svn. (Obtaining masscheck via rsync includes the svninfo.tmp file which is checked as a fallback.)

Simply checking for .svn in the correct location allows users to contribute to masscheck results using svn once more.
Comment 1 Giovanni Bechis 2017-11-03 15:02:22 UTC
Works with "svn, version 1.9.7 (r1800392)" on OpenBSD.
Comment 2 Dave Jones 2017-11-26 22:28:49 UTC
Masscheck confirmed working fine on my CentOS 7 VM running SVN version 1.7.14 for the past 10 months.
Comment 3 Kevin Golding 2017-11-27 10:34:11 UTC
For those of us who want to use the method here: https://wiki.apache.org/spamassassin/CorpusNightlyScript this is a bug. I know it's regarded as an alternative method, but it's still valid as far as I am aware. This extremely simple patch doesn't break anything for anyone using the default method but it does enable those of us who wish to use that method to perform masschecks without manual hacking.

See new features section: https://subversion.apache.org/docs/release-notes/1.7.html
Also noted: https://en.wikipedia.org/wiki/Apache_Subversion#Limitations_and_problems

The bug is valid, if you don't want to fix it then WONTFIX is more appropriate.
Comment 4 Dave Jones 2017-11-27 13:41:38 UTC
Sorry about that.  The problem was not clear until that link was provided. I didn't know there was an alternate way to run the masscheck besides the https://wiki.apache.org/spamassassin/NightlyMassCheck.  I see the CorpusNightlyScript now at the bottom of that page.

What is the difference with the CorpusNightlyScript way?  I will be glad to fix this once I understand what is needed.  I am familiar with the automasscheck-minimal.sh but not with this alternative way.
Comment 5 Kevin Golding 2017-11-27 14:00:45 UTC
I believe the biggest difference, and the reason I personally prefer using it, is that it is sh rather than bash - as a FreeBSD user bash is an additional dependency that requires installing and I prefer not to given the Perl script works fine for me.

I believe it also runs more efficiently on my machines. I never really took notes on the matter but when I tried the newer approach I had greater system load and being UK based masschecks are ideally run at a time of naturally increased load anyway. It's likely adjustable, but I as there's a method that doesn't need adjusting it was my prefered option.

This is JM's original version and it's what I initially setup my masschecks with, I found it simple and straightforward. The updated method seemed less intuitive to me so when I rebuild masscheck boxes now I prefer to use the original still. The results that get uploaded are still valid data.

Since the code to run this method is still in the repo I would suggest either the fix be applied or the code and documentation be removed.

Btw, I don't know why I show as NoCLA since I do have one. I assume perhaps it was never linked to my bugzilla account? However I would assume the patch as trivial enough for it not to be an issue.
Comment 6 Giovanni Bechis 2017-12-28 07:32:57 UTC
In trunk automasscheck-minimal.sh no more requires bash(1) and is *BSD compatible.
Comment 7 Kevin Golding 2017-12-28 20:33:31 UTC
That's not my experience, but regardless, the method I use is included in the official codebase and doesn't work without the suggested patch. However I can see there's no interest in fixing the problem so there's not much point in leaving this open.
Comment 8 Giovanni Bechis 2017-12-28 22:36:27 UTC
IMHO the patch seems fine, it should be committed or we should change the related documentation on the wiki.
Comment 9 Dave Jones 2018-01-07 15:26:02 UTC
Committed attached patch in trunk revision 1820470.