Bug 7441 - SPF Plugin fails to parse temperror and permerror from Received-SPF and Authentication Results headers.
Summary: SPF Plugin fails to parse temperror and permerror from Received-SPF and Authe...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: 3.4.2
Hardware: Other FreeBSD
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 16:48 UTC by Bruce Thompson
Modified: 2017-08-24 10:54 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
SPF.pm patch text/plain None Bruce Thompson [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bruce Thompson 2017-06-27 16:48:00 UTC 
Created attachment 5452 [details]
SPF.pm patch

Per RFC 4408 Received-SPF headers may have TempError and PermError results.

The regexes in SPF.pm do not recognize either of these results.

Attached is a patch against 3.4.1-001 which corrects.
Comment 1 Adam Katz 2017-06-28 00:23:21 UTC 
Bruce works with me.  This code looks good to me but I'm not as expert in our code as I am in our rules.  It looks like we missed these pieces when we added the error conditions.
Comment 2 Karsten Bräckelmann 2017-08-24 10:54:00 UTC 
Thanks, Bruce! Committed to trunk and stable 3.4 branch.

Sending        Plugin/SPF.pm
Committed revision 1806022.

Sending        Plugin/SPF.pm
Committed revision 1806023.

Closing RESOLVED FIXED.