Bug 7455 - AWL and TxRep Need Documentation and Feature Parity
Summary: AWL and TxRep Need Documentation and Feature Parity
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: 3.4 SVN branch
Hardware: PC Windows NT
: P2 enhancement
Target Milestone: Future
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-10 01:53 UTC by Kevin A. McGrail
Modified: 2023-04-28 01:09 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2017-08-10 01:53:05 UTC 
With AWL, you could whitelist/blacklist an email with the spamassassin executable:

Specifically

     --add-addr-to-whitelist=addr      Add addr to persistent address whitelist
     --add-addr-to-blacklist=addr      Add addr to persistent address blacklist
     --remove-addr-from-whitelist=addr Remove addr from persistent address list

Those commands need to be clarified as AWL only (for now)

And extend them for all persistent blacklist/whitelist engines (AWL and/or TXrep and/or xyz)

We should also clarify that the command for whitelist, weights the address in the whitelist to the extreme.  However, new emails could evolve the entry.
Comment 1 Benny Pedersen 2017-08-10 13:59:00 UTC 
also that TxRep does not support SA-Grey 3dr party plugin, is this planned to be added to TxRep
Comment 2 Kevin A. McGrail 2017-08-10 14:56:47 UTC 
I've never even heard of that plugin so I doubt there is any work planned around supporting TXRep with SA-Grey.  Perhaps open a ticket and if you can submit even a framework of code, that would be helpful
Comment 3 Benny Pedersen 2017-08-10 15:15:10 UTC 
link to current hopefully

https://github.com/szepeviktor/spamassassin-sagrey

i can provide what i do, just not commit it to sa
Comment 4 RW 2017-08-10 17:12:00 UTC 
SAGrey checks for AWL like this:

  ($permsgstatus->get_names_of_tests_hit() =~ /\bAWL\b/)

it's SAGrey that needs to be updated rather than TxRep.
Comment 5 RW 2017-08-10 17:19:30 UTC 
(In reply to RW from comment #4)
> it's SAGrey that needs to be updated rather than TxRep.

Actually that's not quite correct because TxRep can do score averaging for IP addresses etc, so it would exempt more than an AWL hit.
Comment 6 Karsten Bräckelmann 2023-04-28 01:09:37 UTC 
(In reply to Kevin A. McGrail from comment #0)
> With AWL, you could whitelist/blacklist an email with the spamassassin
> executable:
> 
> Specifically
> 
>      --add-addr-to-whitelist=addr      Add addr to persistent address whitelist
>      --add-addr-to-blacklist=addr      Add addr to persistent address blacklist
>      --remove-addr-from-whitelist=addr Remove addr from persistent address list

These are implemented in SA 4.0.x (and since 3.4.1 when TxRep was first included) as

  sub blocklist_address
  sub welcomelist_address
  sub remove_address

and called from SpamAssassin.pm / spamassassin executable via call_plugins().

spamassassin executable options' documentation seems appropriate, and overall TxRep plugin documentation extensive.

Closing RESOLVED FIXED.