Bug 7459 - URIBL_DBL_SPAM naming problem
Summary: URIBL_DBL_SPAM naming problem
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.3.2
Hardware: PC Linux
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-16 08:45 UTC by Sebastian Willing
Modified: 2018-01-28 19:11 UTC (History)
6 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add Spamhaus description to related rules patch None Giovanni Bechis [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Willing 2017-08-16 08:45:30 UTC 
Current rule description:
describe        URIBL_DBL_SPAM   Contains an URL listed in the DBL blocklist


URIBL_DBL_SPAM is a Spamhaus DBL DNSBL rule and not related to URIBL. This is causing confusion.

The rule should be renamed to "SPAMHAUS_DBL_SPAM" or at least the description should be extended to "Contains an URL listed in the Spamhaus DBL blocklist".
Comment 1 RW 2017-08-16 12:31:16 UTC 
URIBL_DBL_SPAM is called that because it's a URI BlockList. All such rules start with URIBL_ and are in a file called 25_uribl.cf. URIBL_DBL_SPAM is one of many such rules that have nothing to do with uribl.com.
Comment 2 Kevin A. McGrail 2017-08-16 13:01:29 UTC 
+1 for changing the description
Comment 3 Sebastian Willing 2017-08-16 13:11:52 UTC 
(In reply to RW from comment #1)
> URIBL_DBL_SPAM is called that because it's a URI BlockList. All such rules
> start with URIBL_ and are in a file called 25_uribl.cf. URIBL_DBL_SPAM is
> one of many such rules that have nothing to do with uribl.com.

Sorry, didn't know.

The buzzword "Spamhaus" should be put into the description.
Comment 4 RW 2017-08-16 13:32:09 UTC 
The following are all spamhaus:

describe        URIBL_SBL        Contains an URL's NS IP listed in the SBL blocklist
    describe        URIBL_SBL_A    Contains URL's A record listed in the SBL blocklist
describe        URIBL_DBL_SPAM   	Contains a spam URL listed in the DBL blocklist
describe        URIBL_DBL_PHISH	 	Contains a Phishing URL listed in the DBL blocklist
describe        URIBL_DBL_MALWARE  	Contains a malware URL listed in the DBL blocklist
describe        URIBL_DBL_BOTNETCC	Contains a botned C&C URL listed in the DBL blocklist
describe        URIBL_DBL_ABUSE_SPAM	Contains an abused spamvertized URL listed in the DBL blocklist
describe        URIBL_DBL_ABUSE_REDIR  	Contains an abused redirector URL listed in the DBL blocklist
describe        URIBL_DBL_ABUSE_PHISH	Contains an abused phishing URL listed in the DBL blocklist
describe        URIBL_DBL_ABUSE_MALW	Contains an abused malware URL listed in the DBL blocklist
describe        URIBL_DBL_ABUSE_BOTCC  	Contains an abused botnet C&C URL listed in the DBL blocklist
describe        URIBL_DBL_ERROR  Error: queried the DBL blocklist for an IP
Comment 5 John Hardin 2017-08-16 17:03:24 UTC 
+1 for changing the descriptions
Comment 6 Giovanni Bechis 2017-11-17 07:34:44 UTC 
Created attachment 5484 [details]
Add Spamhaus description to related rules

I am all for this, diff added to add description to Spamhaus related rules.
Comment 7 Dave Jones 2018-01-28 19:11:08 UTC 
Sending        25_uribl.cf
Transmitting file data .done
Committing transaction...
Committed revision 1822476.