Bug 7461 - 20_meta_tests.cf distributed in version 1799552 looks older than 1799401
Summary: 20_meta_tests.cf distributed in version 1799552 looks older than 1799401
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: sa-update (show other bugs)
Version: 3.4.1
Hardware: All FreeBSD
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-22 09:27 UTC by Stoyan Dimov
Modified: 2018-08-28 04:43 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stoyan Dimov 2017-08-22 09:27:32 UTC 
I hit an issue addressed in bug 7411 (https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7411). When I checked my 20_meta_tests.cf file I did not see the changes commited in svn revision 1792301.

I manually downloaded current rules from http://sa-update.ena.com/1799552.tar.gz and I noticed that files are dated March 15th.

I checked my backups and see that sa-update downloaded version 1799552 on 2017-06-24. I downloaded the previous version - 1799401 from http://sa-update.ena.com/1799401.tar.gz and I found out that files are dated Jun 22nd and 20_meta_tests.cf does have the changes commited in revision 1792301.

Looks like at least 20_meta_tests.cf got reverted between updates 1799401 and 1799552. There might be others. Here is the list of files that got changed:
$ diff -rq 1799401 1799552                                                      Files 1799401/20_dnsbl_tests.cf and 1799552/20_dnsbl_tests.cf differ
Files 1799401/20_freemail_domains.cf and 1799552/20_freemail_domains.cf differ
Files 1799401/20_meta_tests.cf and 1799552/20_meta_tests.cf differ
Files 1799401/50_scores.cf and 1799552/50_scores.cf differ
Files 1799401/72_active.cf and 1799552/72_active.cf differ
Files 1799401/72_scores.cf and 1799552/72_scores.cf differ
Files 1799401/STATISTICS-set0-72_scores.cf.txt and 1799552/STATISTICS-set0-72_scores.cf.txt differ
Files 1799401/STATISTICS-set1-72_scores.cf.txt and 1799552/STATISTICS-set1-72_scores.cf.txt differ
Comment 1 Merijn van den Kroonenberg 2017-08-22 09:43:26 UTC 
The rules have indeed been reverted to the ones of March 15th, as thats the last good state. Due to migration problems the newer rule versions were not published correctly. This is a known issue.

But unless you follow the mailinglist it is hard to see the 'current state' of SA. It might be a good idea to publish something on the SA home page about this. Maybe in a news item, or maybe in a separate "Current status" info block.
Comment 2 Kevin A. McGrail 2017-08-22 11:08:31 UTC 
Thanks Merjin.  Because there aren't many issues that not having a current rule set generated causes, I'm -1 on a public announcement.  As long as sa-update runs without error, that's priority 1.  

And the sa-update infrastructure is used to roll a new release so that is priority 2.

After that, yes, the rules are a bit hodgepodge because 72_scores.cf was generating badly. 

We might be missing a rule or two but if that is the only issue, I consider this a  duplicate of the known issue.

BZ, do you have an issue beyond the one mozilla bug? That is an important issue but I want to make sure it isn't larger.
Comment 3 Stoyan Dimov 2017-08-22 12:44:38 UTC 
Nothing else has caught my attention.
Comment 4 Kevin A. McGrail 2018-08-28 04:43:25 UTC 
Rule generation has long since been fixed.  4 Huzzahs for Dave Jones and the SA SysAdmins!