Bug 7463 - FP on MISSING_MIMEOLE with Office 2016
Summary: FP on MISSING_MIMEOLE with Office 2016
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-24 00:29 UTC by Karsten Bräckelmann
Modified: 2018-03-01 17:35 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Bräckelmann 2017-08-24 00:29:08 UTC 
Thomas A. McLeary wrote in bug 6346 comment 4:

Can this be reopened? Office 2016 is out so this rule is broken again.

To future proof this rule (assuming MS stays with the same X-Mailer format) how about changing the rule that looks for the X-Mailer header. It looks like 2003 and earlier had the build number, e.g.:

X-Mailer: Microsoft Office Outlook, Build 11.0.5510

Whereas 2007 and later is just the main version, e.g.:

X-Mailer: Microsoft Outlook 14.0

So maybe something like this:

20_head_tests.cf:
header   __HAS_OFFICE12PLUS_IN_MAILER	X-Mailer =~ /^Microsoft (?:Office )?Outlook 1[2-9]\.0/
meta     MISSING_MIMEOLE	(__HAS_MSMAIL_PRI && !__HAS_MIMEOLE && !__HAS_SQUIRRELMAIL_IN_MAILER && !__HAS_OFFICE12PLUS_IN_MAILER)

That would at least cover the next 3 versions through Office 19.
Comment 1 Karsten Bräckelmann 2017-08-24 00:40:33 UTC 
Thanks for the report, Thomas. Added version 16 to the list for now.

Sending        rules/20_head_tests.cf
Committed revision 1805980.

I am reluctant to proactively add versions that don't yet exist and aren't clear to have the same behavior in future. Playing whack-a-mole with Office versions and seeing this come up every other year isn't great, either, though...

For reference, see original bug 6346 and bug 7122.
Comment 2 Giovanni Bechis 2017-12-07 23:52:55 UTC 
IMHO adding version checks based on headers that not yet exists on the wild can bring even more FP (or FN, who knows).
We should fix the rules accordingly when next Outlook version will be released.
Comment 3 Giovanni Bechis 2018-03-01 17:35:34 UTC 
Rule fixed in r1805980 (Outlook 2016 test added).
When/If a new version of Microsoft Outlook will be out we will fix the according rule.