Bug 7624 - FromNameSpoof: fns_ignore_dkim is not a hash
Summary: FromNameSpoof: fns_ignore_dkim is not a hash
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 3.4.2
Hardware: PC Linux
: P2 blocker
Target Milestone: 3.4.3
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-18 13:03 UTC by Manuel Mausz
Modified: 2018-09-26 16:18 UTC (History)
4 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Mausz 2018-09-18 13:03:30 UTC 
Enabling FromNameSpoof without any other configuration results in:
> spamd[2061]: rules: failed to run DKIM_ADSP_CUSTOM_LOW test, skipping:
> spamd[2061]:  (Not a HASH reference at /..../Mail/SpamAssassin/Plugin/FromNameSpoof.pm line 319.
> spamd[2061]: )

The relevant line is:
> return 0 if ($self->{main}{conf}{fns_ignore_dkim}{$addr});

I assume this is because fns_ignore_dkim is of type $Mail::SpamAssassin::Conf::CONF_TYPE_STRINGLIST, which is an array of strings rather than a hashmap.
Comment 1 Paul Stead 2018-09-19 08:57:16 UTC 
Have seen this, will adjust when less busy :)
Comment 2 Henrik Krohns 2018-09-26 14:21:51 UTC 
Sending        spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
Sending        trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
Transmitting file data ..done
Committing transaction...
Committed revision 1842029.
Comment 3 Paul Stead 2018-09-26 16:18:52 UTC 
(In reply to Henrik Krohns from comment #2)
> Sending        spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
> Sending        trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
> Transmitting file data ..done
> Committing transaction...
> Committed revision 1842029.

Thanks for cleaning this up - I'll add more comments and fix things from your other comments