Bug 7655 - '/etc/mail/spamassassin/sa-update-keys/': No such file or directory
Summary: '/etc/mail/spamassassin/sa-update-keys/': No such file or directory
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: sa-update (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Linux
: P2 normal
Target Milestone: 3.4.3
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-09 20:29 UTC by Alessandro Vesely
Modified: 2018-11-10 14:58 UTC (History)
4 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Output of sa-update -D gpg --import GPG.KEY text/plain None Alessandro Vesely [HasCLA]
Proposed patch patch None Alessandro Vesely [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Vesely 2018-11-09 20:29:05 UTC 
Created attachment 5624 [details]
Output of sa-update -D gpg --import GPG.KEY

After making and installing current trunk, sa-update fails to import keys on the first run, as documented in INSTALL at line ~170.

The failure happens because the directory doesn't exist.
I attach command and output w/o line breaks.
Comment 1 Alessandro Vesely 2018-11-09 20:30:48 UTC 
Created attachment 5625 [details]
Proposed patch

I also attach a patch
Comment 2 Kevin A. McGrail 2018-11-09 21:18:44 UTC 
This patch is on the edge of non-trivial.  Can you submit an ICLA? https://www.apache.org/licenses/icla.pdf
Comment 3 Henrik Krohns 2018-11-09 22:34:40 UTC 
He already HasCLA...

Anyway, the patch needed minor argument fix.

Also I noticed sa-update imported default key over and over again. That's because GnuPG prior to 2.1 used secring.gpg which it checks for, but 2.1 uses trustdb.gpg. I changed to that, since probably everyone uses atleast 2.1 these days... and if not, it simply imports it again and again like before, benign issue.

Sending        sa-update.raw
Transmitting file data .done
Committing transaction...
Committed revision 1846268.
Comment 4 Giovanni Bechis 2018-11-10 08:15:59 UTC 
This is a bugfix and should be committed to 3.4
tree as well iff it hasn't been done yet.
Comment 5 Henrik Krohns 2018-11-10 10:38:42 UTC 
I guess it doesn't brake anything.

Sending        sa-update.raw
Transmitting file data .done
Committing transaction...
Committed revision 1846293.
Comment 6 Kevin A. McGrail 2018-11-10 14:58:15 UTC 
Commit to 3.4 as well
Comment 7 Kevin A. McGrail 2018-11-10 14:58:43 UTC 
Which I see was done.  r1846293.  --- Closing