SA Bugzilla – Bug 7788
List of Upstream Rules with 'no description set'
Last modified: 2022-04-22 04:42:47 UTC
Below is debug output using SA 3.4.4 with warnings for 'no description set'. The intent is to clean the debug output a little bit and to discourage creating scoring rules with no description. I've set the severity to 'trivial' as it does not appear to affect SpamAssassin performance. However, it does generate a 'warning', and warnings would imply a response to them. Should descriptions be made for these rules? dbg: config: warning: no description set for TVD_FINGER_02 dbg: config: warning: no description set for JM_I_FEEL_LUCKY dbg: config: warning: no description set for THEBAT_UNREG dbg: config: warning: no description set for FORGED_RELAY_MUA_TO_MX dbg: config: warning: no description set for STOX_AND_PRICE dbg: config: warning: no description set for SB_GIF_AND_NO_URIS dbg: config: warning: no description set for LONG_TERM_PRICE dbg: config: warning: no description set for SPOOFED_FREEMAIL dbg: config: warning: no description set for KB_RATWARE_OUTLOOK_08 dbg: config: warning: no description set for KB_FAKED_THE_BAT dbg: config: warning: no description set for HTML_TITLE_SUBJ_DIFF dbg: config: warning: no description set for FSL_HELO_NON_FQDN_1 dbg: config: warning: no description set for STOX_REPLY_TYPE_WITHOUT_QUOTES dbg: config: warning: no description set for LOTTERY_1 dbg: config: warning: no description set for BUG6152_INVALID_DATE_TZ_ABSURD dbg: config: warning: no description set for MSGID_DOLLARS_RANDOM dbg: config: warning: no description set for HIGH_CODEPAGE_URI dbg: config: warning: no description set for HK_LOTTO dbg: config: warning: no description set for L_SPAM_TOOL_13 dbg: config: warning: no description set for FSL_HELO_BARE_IP_1 dbg: config: warning: no description set for MIME_BOUND_EQ_REL dbg: config: warning: no description set for TVD_EB_PHISH dbg: config: warning: no description set for HELO_LH_LD dbg: config: warning: no description set for CURR_PRICE dbg: config: warning: no description set for MSOE_MID_WRONG_CASE dbg: config: warning: no description set for RCVD_FORGED_WROTE2 dbg: config: warning: no description set for JM_TORA_XM dbg: config: warning: no description set for FSL_HELO_SETUP dbg: config: warning: no description set for GEO_QUERY_STRING dbg: config: warning: no description set for REPLYTO_WITHOUT_TO_CC dbg: config: warning: no description set for FSL_INTERIA_ABUSE dbg: config: warning: no description set for KB_RATWARE_MSGID dbg: config: warning: no description set for CTYPE_001C_B dbg: config: warning: no description set for PDS_FROM_2_EMAILS dbg: config: warning: no description set for HK_RCVD_IP_MULTICAST dbg: config: warning: no description set for FORGED_SPF_HELO dbg: config: warning: no description set for MULTIPART_ALT_NON_TEXT dbg: config: warning: no description set for HK_GOLDDUST dbg: config: warning: no description set for BASE64_LENGTH_78_79 dbg: config: warning: no description set for FSL_HELO_DEVICE dbg: config: warning: no description set for FAKE_REPLY_C dbg: config: warning: no description set for JM_RCVD_QMAILV1 dbg: config: warning: no description set for DOS_DEREK_AUG08 dbg: config: warning: no description set for STOCK_PRICES dbg: config: warning: no description set for KB_RATWARE_OUTLOOK_12 dbg: config: warning: no description set for KB_RATWARE_BOUNDARY dbg: config: warning: no description set for TVD_RCVD_SPACE_BRACKET dbg: config: warning: no description set for TVD_SUBJ_NUM_OBFU_MINFP dbg: config: warning: no description set for HELO_FRIEND dbg: config: warning: no description set for LOTTERY_PH_004470 dbg: config: warning: no description set for FSL_FAKE_HOTMAIL_RVCD dbg: config: warning: no description set for CTYPE_001C_A dbg: config: warning: no description set for DOS_STOCK_BAT2 dbg: config: warning: no description set for HK_SCAM dbg: config: warning: no description set for HELO_LOCALHOST dbg: config: warning: no description set for KB_DATE_CONTAINS_TAB dbg: config: warning: no description set for FROM_MISSP_SPF_FAIL dbg: config: warning: no description set for STOX_BOUND_090909_B dbg: config: warning: no description set for HTTPS_HTTP_MISMATCH dbg: config: warning: no description set for HELO_OEM dbg: config: warning: no description set for LM_YESMAIL_MARKETER1 dbg: config: warning: no description set for KB_RATWARE_OUTLOOK_MID dbg: config: warning: no description set for LIVEFILESTORE dbg: config: warning: no description set for TVD_PP_PHISH dbg: config: warning: no description set for TVD_SPACE_RATIO dbg: config: warning: no description set for KB_RATWARE_OUTLOOK_16 dbg: config: warning: no description set for MID_DEGREES dbg: config: warning: no description set for SHORT_TERM_PRICE dbg: config: warning: no description set for X_MAILER_CME_6543_MSN dbg: config: warning: no description set for FSL_HELO_FAKE dbg: config: warning: no description set for HK_NAME_MR_MRS dbg: config: warning: no description set for HK_WIN dbg: config: warning: no description set for STOX_REPLY_TYPE
Wouldn't hurt to add descriptions. Patches welcome
I removed the pointless "warning:" from debug messages, as these are merely informational. It's well known that descriptions are lacking (as said, patches welcome), so it's not necessary keep bug like this open. Sending trunk/lib/Mail/SpamAssassin/Conf/Parser.pm Transmitting file data .done Committing transaction... Committed revision 1900130.