Bug 7882 - Inconsistent use of the word USER.
Summary: Inconsistent use of the word USER.
Status: NEW
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Linux
: P2 trivial
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-06 00:22 UTC by jidanni
Modified: 2021-02-06 01:46 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jidanni 2021-02-06 00:22:23 UTC 
spamassassin --test-mode says:

  10 USER_IN_BLOCKLIST      From: address is in the user's block-list
-100 USER_IN_WELCOMELIST    user is listed in 'welcomelist_from'

Let's take a closer look:
  10 USER_IN_BLOCKLIST      From: address is in the user's block-list
     AAAA                                           BBBB

Inconsistent use of the word 'user'.  AAAA is certainly not BBBB.

-100 USER_IN_WELCOMELIST    user is listed in 'welcomelist_from'
     CCCC                   DDDD
OK, that's better, it seems.
(But maybe we should be talking about addresses, not users... But maybe
that would break scripts.)


Wait, more problems:
  10 USER_IN_BLOCKLIST      From: address is in the user's block-list
                            XXXX
-100 USER_IN_WELCOMELIST    user is listed in 'welcomelist_from'
                                                           YYYY

Well for XXXX it is quite clear which header it is talking about.

For YYYY all that is left is maybe it is talking about From: .
But maybe XXXX is also just one of the matching headers, the rest if
any, aren't mentioned.
Comment 1 Kevin A. McGrail 2021-02-06 01:46:32 UTC 
Agreed.  Will look at this.