Bug 7895 - No X-Spam-ASN tag for 3.4
Summary: No X-Spam-ASN tag for 3.4
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.4.5
Hardware: PC Linux
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-27 23:52 UTC by Maciej S. Szmigiero
Modified: 2021-03-29 12:23 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2021-03-27 23:52:00 UTC 
There is no longer a "X-Spam-ASN" tag present with SA 3.4 (at least with 3.4.5), even when the ASN plugin is enabled.

This issue is likely caused by SVN commit 1877554 ("Use new check_asn() function instead of X-ASN metadata in rules (Bug 7791))" (git commit 522fec3a4073c), since it introduced a check in "rules/25_asn.cf" for presence of "has_check_asn" in the ASN plugin before performing an automatic ASN lookup.

"has_check_asn" is not present in the ASN plugin in 3.4 branch, but the comment above that check in "rules/25_asn.cf" suggests the intention was to disable the automatic ASN lookup only for 4.0 branch, that is, opposite what the code actually does.

In fact, when I reverse that "has_check_asn" condition in "rules/25_asn.cf" the "X-Spam-ASN" header returns.
Comment 1 Henrik Krohns 2021-03-29 12:16:40 UTC 
My bad, fixed. Apparently not many people looked for it. :-)

Sending        rules/25_asn.cf
Transmitting file data .done
Committing transaction...
Committed revision 1888168.
Comment 2 Henrik Krohns 2021-03-29 12:17:23 UTC 
... and resolving.
Comment 3 Maciej S. Szmigiero 2021-03-29 12:23:41 UTC 
Thanks Henrik.