Bug 8250 - t/tainted_msg.t fails if Test module not installed even though it doesn't need it
Summary: t/tainted_msg.t fails if Test module not installed even though it doesn't nee...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Regression Tests (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P2 normal
Target Milestone: 4.0.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-26 10:00 UTC by Sidney Markowitz
Modified: 2024-04-26 10:08 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sidney Markowitz 2024-04-26 10:00:13 UTC 
Test is a core module in perl, but perl on Amazon Linux doesn't have it.

t/tainted_msg.t loads a test plugin taintcheckplugin.pm that has "use Test;" but doesn't reference anything from the Test module.

The only thing that the "use Test;" line does is cause the test to fail when run under a perl that does not have the Test module.

I have a report of that happening from someone who has installed on an Amazon Linux ec2 instance on aws using the perl provided with it.

I'll remove the "use Test;" line.
Comment 1 Sidney Markowitz 2024-04-26 10:08:12 UTC 
trunk % svn ci -m "bug 8250 - Remove unnecessary use Test;" t/data/taintcheckplugin.pm
Sending        t/data/taintcheckplugin.pm
Transmitting file data .done
Committing transaction...
Committed revision 1917349.