Bug 8251 - Building requires Perl Critic
Summary: Building requires Perl Critic
Status: NEW
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: 4.0.1
Hardware: All All
: P2 enhancement
Target Milestone: 4.0.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-29 21:31 UTC by Todd Rinaldo
Modified: 2024-04-30 21:27 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Todd Rinaldo 2024-04-29 21:31:43 UTC 
I'd like to suggest that Perl::Critic modules not be required even for build_requires. Instead, make them author tests with something similar to this

unless ( $ENV{RELEASE_TESTING} ) {
    plan( skip_all => "Author tests not required for installation" );
}
Comment 1 Sidney Markowitz 2024-04-29 22:00:18 UTC 
I agree. Those should be developer only tests that are not relevant to normal installs. If nobody else in the PMC disagrees I'll make a change to that effect.
Comment 2 Giovanni Bechis 2024-04-30 21:27:34 UTC 
+1 on removing Perl::Critic from default "build_requires".