Bug 8254 - t/sa_compile.t does not run if re2c is not in /usr/bin/
Summary: t/sa_compile.t does not run if re2c is not in /usr/bin/
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Regression Tests (show other bugs)
Version: 4.0.1
Hardware: PC Linux
: P2 normal
Target Milestone: 4.0.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-06 03:41 UTC by Todd Rinaldo
Modified: 2024-05-06 08:21 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Todd Rinaldo 2024-05-06 03:41:51 UTC 
If I run Makefile.PL as:

perl Makefile.PL RE2C_BIN=/usr/local/cpanel/3rdparty/bin/re2c

t/sa_compile.t doesn't seem to know about this and does not find re2c. Even if you fake re2c_version_new_enough that it's there, it still fails later in a compile. Somehow re2c location should be passed through?
Comment 1 Sidney Markowitz 2024-05-06 06:14:40 UTC 
I see another place in t/sa_compile.t where it needs to use the path for re2c that is compiled into sa-compile in addition to the one where you tried a fake re2c_version_new_enough. I'll put together a patch for the test that reads the compiled sa-compile file to get RE2C_BIN.
Comment 2 Sidney Markowitz 2024-05-06 08:21:19 UTC 
% svn ci -m "bug 8254 - fix sa-compile test to work with Makefile.PL RE2C_BIN option" t/sa_compile.t
Sending        t/sa_compile.t
Transmitting file data .done
Committing transaction...
Committed revision 1917531.