Bug 95 - SUBJ_ALL_CAPS regexp uses exponential backoff
Summary: SUBJ_ALL_CAPS regexp uses exponential backoff
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 2.11
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: Craig Hughes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-03-10 12:00 UTC by Rob McMillin
Modified: 2002-03-16 18:25 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status
Patch for SUBJ_IS_ALL_CAPS eval test patch None Rob McMillin [NoCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Rob McMillin 2002-03-10 12:00:28 UTC
The SUBJ_ALL_CAPS regexp rule uses exponential backoff, which can be a problem
if you have a Perl version that doesn't handle such stuff gracefully.  In
general, though, because of the regexp's suboptimal behavior in the first place,
it ought to be avoided and replaced with an eval test.  I already had a
discussion about this with Charlie Watts <cewatts@frontier.net> on the list. 
I'll attach my patches, which I already submitted to the list, in an appended
document.
Comment 1 Rob McMillin 2002-03-10 12:01:57 UTC
Created attachment 6 [details]
Patch for SUBJ_IS_ALL_CAPS eval test
Comment 2 Rob McMillin 2002-03-10 12:02:41 UTC
header SUBJ_ALL_CAPS	eval:subject_is_all_caps
describe SUBJ_ALL_CAPS  SUBJECT TEXT IS ALL CAPS
score SUBJ_ALL_CAPS	2