Created attachment 22561 [details]
Excel 2002 spreadsheet demonstrating a bug caused by cells with 3D references

Calling toString() on a cell with a 3D reference containing another sheet in the workbook causes an IndexOutOfBoundsException.


Example:

 FileInputStream fis = new FileInputStream(argv[0]);
 POIFSFileSystem fs  = new POIFSFileSystem(fis);
 HSSFWorkbook wb = new HSSFWorkbook(fs); 
 HSSFSheet sheet = wb.getSheetAt(0);
 HSSFRow row = sheet.getRow(1);
 HSSFCell cell = row.getCell((short)1);  
 System.out.println(cell);

Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 2, Size: 2
        at java.util.ArrayList.RangeCheck(Unknown Source)
        at java.util.ArrayList.get(Unknown Source)
        at org.apache.poi.hssf.model.Workbook.getSheetName(Workbook.java:534)
        at
org.apache.poi.hssf.model.Workbook.findSheetNameFromExternSheet(Workbook.java:1867)
        at org.apache.poi.hssf.model.Workbook.getSheetReferences(Workbook.java:1849)
        at org.apache.poi.hssf.usermodel.HSSFWorkbook.getSheetReferences(HSSFWorkbook.java:788)
        at org.apache.poi.hssf.usermodel.HSSFWorkbook.getSheetReferences(HSSFWorkbook.java:79)
        at org.apache.poi.hssf.record.formula.Ref3DPtg.getSheetName(Ref3DPtg.java:169)
        at org.apache.poi.hssf.record.formula.Ref3DPtg.toFormulaString(Ref3DPtg.java:182)
        at org.apache.poi.hssf.model.FormulaParser.toFormulaString(FormulaParser.java:925)
        at org.apache.poi.hssf.model.FormulaParser.toFormulaString(FormulaParser.java:858)
        at org.apache.poi.hssf.usermodel.HSSFCell.getCellFormula(HSSFCell.java:686)
        at org.apache.poi.hssf.usermodel.HSSFCell.toString(HSSFCell.java:1031)
        at java.lang.String.valueOf(Unknown Source)
        at java.io.PrintStream.println(Unknown Source)
        at bs.main(bs.java:69)


The exception is raised in POI-3.1-FINAL and POI-3.5-beta2.

The problem originates in Workbook.findSheetNameFromExternSheet(), 
This method calls LinkTable.getIndexToSheet():

public short getIndexToSheet(short num) {
  return _externSheetRecord.getREFRecordAt(num).getIndexToFirstSupBook();
}

ExternSheetSubRecord.getIndexToFirstSubBook() returns 2, which is then used to get the 2nd element of the Workbook’s boundsheets, a list of length 2.

5 ExternSheetSubRecords are created from the attached spreadsheet, they are:

   supbookindex =0
   1stsbindex   =0
   lastsbindex  =0

   supbookindex =1
   1stsbindex   =2
   lastsbindex  =2

   supbookindex =2
   1stsbindex   =1
   lastsbindex  =1

   supbookindex =0
   1stsbindex   =-1
   lastsbindex  =-1

    supbookindex =0
   1stsbindex   =1
   lastsbindex  =1

It seems that the original DocumentInputStream could be off, 3 non -1 supbookindices are created, and the 2nd 1stsbindex returns 2...